JGonera has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94468
Change subject: Make child overlay hide the parent forcefully
......................................................................
Make child overlay hide the parent forcefully
So that when clicking "What does this mean?" in photo upload preview
doesn't ask the user if they want to cancel the upload.
Change-Id: Ieb75812bb9f1eb603a6e66aa09469feb97b27a5c
---
M javascripts/common/Overlay.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/68/94468/1
diff --git a/javascripts/common/Overlay.js b/javascripts/common/Overlay.js
index 917f787..62fa02e 100644
--- a/javascripts/common/Overlay.js
+++ b/javascripts/common/Overlay.js
@@ -56,7 +56,7 @@
// FIXME: prevent zooming within overlays but don't
break the rendering!
// M.lockViewport();
if ( this.parent ) {
- this.parent.hide();
+ this.parent.hide( true );
}
this.$el.appendTo( this.appendTo );
--
To view, visit https://gerrit.wikimedia.org/r/94468
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb75812bb9f1eb603a6e66aa09469feb97b27a5c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
