Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/94602


Change subject: Do not escape title attribute twice for tooltip-iwiki
......................................................................

Do not escape title attribute twice for tooltip-iwiki

When building the html the title attribute gets already escaped, so
getting text is enough. Changing wfMessage to $this->msg to use the
context for parsing.

Bug: 55865
Change-Id: I779d3df414b0dbdfab415129baa3e7209e4067d6
---
M includes/SkinTemplate.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/02/94602/1

diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index f25545d..0806aca 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -159,7 +159,7 @@
                                        $language_urls[] = array(
                                                'href' => 
$languageLinkTitle->getFullURL(),
                                                'text' => $ilLangName,
-                                               'title' => wfMessage( 
'tooltip-iwiki', $languageLinkTitle->getText(), $ilLangLocalName )->escaped(),
+                                               'title' => $this->msg( 
'tooltip-iwiki', $languageLinkTitle->getText(), $ilLangLocalName )->text(),
                                                'class' => $class,
                                                'lang' => wfBCP47( 
$ilInterwikiCode ),
                                                'hreflang' => wfBCP47( 
$ilInterwikiCode ),

-- 
To view, visit https://gerrit.wikimedia.org/r/94602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I779d3df414b0dbdfab415129baa3e7209e4067d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to