jenkins-bot has submitted this change and it was merged.
Change subject: Fix student name in dialogue for removing article
......................................................................
Fix student name in dialogue for removing article
In the students table at the end of course pages, next to articles
assigned to students, there are links for removing article
assignments. When you click any of those links, a confirmation
dialogue appears. If you click a link to remove an article for a
student other than yourself, the message in the dialogue shows your
user name instead of the student's. This little patch fixes the error.
Change-Id: I6b89544cfa4cdc08aab4ac423074198c64dac85a
---
M includes/pagers/ArticleTable.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Cscott: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/pagers/ArticleTable.php b/includes/pagers/ArticleTable.php
index eac1cf0..b8a0b72 100644
--- a/includes/pagers/ArticleTable.php
+++ b/includes/pagers/ArticleTable.php
@@ -359,7 +359,7 @@
$user = $this->getUser();
if ( $user->getId() !== $article->getUserId() ) {
- $attr['data-student-name'] = $user->getName();
+ $attr['data-student-name'] =
$article->getUser()->getName();
}
if ( $this->isForOneCourse() ) {
--
To view, visit https://gerrit.wikimedia.org/r/91894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b89544cfa4cdc08aab4ac423074198c64dac85a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: Ragesoss <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
