Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94923
Change subject: skip SiteLinkLookupTest in client
......................................................................
skip SiteLinkLookupTest in client
requires db access to SiteLinkTable
Change-Id: I727e1ce84eb0679023b44608087847c8d6e0b847
---
M lib/tests/phpunit/store/SiteLinkLookupTest.php
1 file changed, 7 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/23/94923/1
diff --git a/lib/tests/phpunit/store/SiteLinkLookupTest.php
b/lib/tests/phpunit/store/SiteLinkLookupTest.php
index d632348..0e18665 100644
--- a/lib/tests/phpunit/store/SiteLinkLookupTest.php
+++ b/lib/tests/phpunit/store/SiteLinkLookupTest.php
@@ -22,28 +22,17 @@
*/
class SiteLinkLookupTest extends \MediaWikiTestCase {
- public function instanceProvider() {
- $instances = array();
+ public function setUp() {
+ parent::setUp();
- if ( defined( 'WB_VERSION' ) ) {
- $instances[] = StoreFactory::getStore( 'sqlstore'
)->newSiteLinkCache();
+ if ( !defined( 'WB_VERSION' ) ) {
+ $this->markTestSkipped( "Skipping because
WikibaseClient doesn't have a local site link table." );
}
-
- if ( defined( 'WBC_VERSION' ) ) {
- $instances[] =
WikibaseClient::getDefaultInstance()->getStore( 'sqlstore'
)->getSiteLinkTable();
- }
-
- if ( empty( $instances ) ) {
- $this->markTestIncomplete( 'No sitelink lookup tables
available' );
- }
-
- return $this->arrayWrap( $instances );
}
- /**
- * @dataProvider instanceProvider
- */
- public function testGetConflictsForItem( SiteLinkLookup $lookup ) {
+ public function testGetConflictsForItem() {
+ $lookup = StoreFactory::getStore( 'sqlstore'
)->newSiteLinkCache();
+
$conflicts = $lookup->getConflictsForItem( Item::newEmpty() );
$this->assertTrue( $conflicts === array() );
}
--
To view, visit https://gerrit.wikimedia.org/r/94923
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I727e1ce84eb0679023b44608087847c8d6e0b847
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
