Cscott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94926
Change subject: De-lint JavaScript sources.
......................................................................
De-lint JavaScript sources.
Fix various minor lint and codestyle issues with the JavaScript sources,
so that jenkins test runners can accurately catch new violations.
Note that by convention 'null' is used for "empty" values which are
explicitly assigned/initialized, which allows us to use the
'undefined' value to more accurately identify errors in which
uninitialized fields/variables are used.
Change-Id: I5d5d4634d7450b006120a71c5a9dc9e3193b4e90
---
M resources/ep.addcourse.js
M resources/ep.combobox.js
M resources/ep.enlist.js
M resources/ep.js
M resources/ep.pager.js
M resources/jquery.imageinput.js
6 files changed, 21 insertions(+), 20 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram
refs/changes/26/94926/1
diff --git a/resources/ep.addcourse.js b/resources/ep.addcourse.js
index 2e836a4..425c1a6 100644
--- a/resources/ep.addcourse.js
+++ b/resources/ep.addcourse.js
@@ -28,7 +28,7 @@
for ( i in list ) {
if ( list.hasOwnProperty( i ) ) {
- $element = $( '#' + list[i] ),
+ $element = $( '#' + list[i] );
val = $element.val();
$element.removeAttr( 'value' );
diff --git a/resources/ep.combobox.js b/resources/ep.combobox.js
index 4137f92..37c3b22 100644
--- a/resources/ep.combobox.js
+++ b/resources/ep.combobox.js
@@ -10,9 +10,8 @@
$.widget( "ep.combobox", {
_create: function() {
- var self, input, select, selected, value;
-
- self = this,
+ var input,
+ self = this,
select = this.element.hide(),
selected = select.children( ":selected" ),
value = selected.val() ? selected.text() : "";
diff --git a/resources/ep.enlist.js b/resources/ep.enlist.js
index 3f15212..6c20d34 100644
--- a/resources/ep.enlist.js
+++ b/resources/ep.enlist.js
@@ -20,7 +20,7 @@
userName = $this.attr( 'data-username' ),
bestName = $this.attr( 'data-bestname' ),
role = $this.attr( 'data-role' ),
- $dialog = undefined,
+ $dialog = null,
summaryLabel, summaryInput,
doRemove;
@@ -136,7 +136,7 @@
this.courseId = $this.attr( 'data-courseid' );
this.courseName = $this.attr( 'data-coursename' );
this.selfMode = $this.attr( 'data-mode' ) === 'self';
- this.$dialog = undefined;
+ this.$dialog = null;
this.nameInput = $( '<input>' ).attr( {
'type': 'text',
diff --git a/resources/ep.js b/resources/ep.js
index f0f8408..05afb59 100644
--- a/resources/ep.js
+++ b/resources/ep.js
@@ -8,12 +8,12 @@
( function ( $, mw ) {
- var compatMode = undefined,
+ var compatMode = null,
ep = {
msg: function () {
// Yeah, doing it here, since "mw.loader.using(
'mediawiki.language',"
// does not have mediaWiki.language loaded.
- if ( compatMode === undefined ) {
+ if ( compatMode === null ) {
compatMode = window.mediaWiki.language.gender
=== undefined;
if ( compatMode ) {
diff --git a/resources/ep.pager.js b/resources/ep.pager.js
index 34275aa..e13b996 100644
--- a/resources/ep.pager.js
+++ b/resources/ep.pager.js
@@ -19,20 +19,21 @@
return false;
} );
- var $dialog = undefined,
- $remove = undefined,
- $summaryInput = undefined,
+ var $dialog = null,
+ $remove = null,
+ $summaryInput = null,
showConfirmDialog,
onFail;
showConfirmDialog = function( args, onConfirm ) {
var names, summaryLabel,
- args = $.extend( {
- 'type': 'unknown',
- 'ids': [],
- 'names': []
- }, args ),
deferred = $.Deferred();
+
+ args = $.extend( {
+ 'type': 'unknown',
+ 'ids': [],
+ 'names': []
+ }, args );
$dialog = $( '<div>' ).html( '' ).dialog( {
'title': ep.msg( 'ep-pager-confirm-delete-' +
args.type, args.ids.length ),
@@ -167,7 +168,8 @@
return;
}
- pagerId = $( this ).attr( 'data-pager-id' ),
+ pagerId = $( this ).attr( 'data-pager-id' );
+
args = {
'type': $( this ).attr( 'data-type' ),
'ids': ids,
@@ -181,7 +183,7 @@
$dialog.dialog( 'close' );
if ( $table.find( 'tr' ).length
- ids.length > 1 ) {
- for ( i in ids ) {
+ for ( var i in ids ) {
if (
ids.hasOwnProperty( i ) ) {
$(
'#select-' + pagerId + '-' + ids[i] ).closest( 'tr' ).remove();
}
diff --git a/resources/jquery.imageinput.js b/resources/jquery.imageinput.js
index 3b2de72..6c6f97c 100644
--- a/resources/jquery.imageinput.js
+++ b/resources/jquery.imageinput.js
@@ -16,7 +16,7 @@
var _this = this,
$this = $( _this ),
- $img = undefined;
+ $img = null;
this.setup = function() {
$img = $( '<img>' ).attr( {
@@ -103,7 +103,7 @@
function( data ) {
if ( data.query && data.query.pages ) {
var pages = data.query.pages,
- info;
+ info, p, i;
for ( p in pages ) {
info =
pages[p].imageinfo;
--
To view, visit https://gerrit.wikimedia.org/r/94926
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d5d4634d7450b006120a71c5a9dc9e3193b4e90
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
