Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95083
Change subject: Avoid silly double-parse bug
......................................................................
Avoid silly double-parse bug
* The FlaggableWikiPage object was not getting the WikiPage prepared edit data
Change-Id: Ic21ef4a07af47960ec2913ac9a9353d926737c1d
---
M backend/FlaggableWikiPage.php
M backend/FlaggedRevs.hooks.php
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/83/95083/1
diff --git a/backend/FlaggableWikiPage.php b/backend/FlaggableWikiPage.php
index dc32309..e17bc0b 100644
--- a/backend/FlaggableWikiPage.php
+++ b/backend/FlaggableWikiPage.php
@@ -29,6 +29,16 @@
}
/**
+ * Transfer the prepared edit cache from a WikiPage object
+ *
+ * @param WikiPage $page
+ * @return void
+ */
+ public function preloadPreparedEdit( WikiPage $page ) {
+ $this->mPreparedEdit = $page->mPreparedEdit;
+ }
+
+ /**
* Clear object process cache values
* @return void
*/
diff --git a/backend/FlaggedRevs.hooks.php b/backend/FlaggedRevs.hooks.php
index 6fb52b4..115d750 100644
--- a/backend/FlaggedRevs.hooks.php
+++ b/backend/FlaggedRevs.hooks.php
@@ -383,6 +383,7 @@
if ( !$rev || !$user || !$fa->isReviewable() ) {
return true;
}
+ $fa->preloadPreparedEdit( $article ); // avoid double parse
$title->resetArticleID( $rev->getPage() ); // Avoid extra DB
hit and lag issues
# Get what was just the current revision ID
$prevRevId = $rev->getParentId();
--
To view, visit https://gerrit.wikimedia.org/r/95083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic21ef4a07af47960ec2913ac9a9353d926737c1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
