jenkins-bot has submitted this change and it was merged. Change subject: Optimized imports ......................................................................
Optimized imports Change-Id: I31e94a96c042de102b828fb5e34cadf19def513c --- M DataModel/Claim/ClaimGuid.php M DataModel/Claim/ClaimGuidParser.php M DataModel/Entity/Entity.php M DataModel/Entity/EntityIdValue.php M DataModel/ItemDiff.php M DataModel/MapValueHasher.php M DataModel/Snak/PropertyValueSnak.php M tests/phpunit/ByPropertyIdArrayTest.php M tests/phpunit/Claim/ClaimGuidTest.php M tests/phpunit/Claim/ClaimsTest.php M tests/phpunit/Entity/EntityIdParserTest.php M tests/phpunit/Entity/EntityTest.php M tests/phpunit/Entity/ItemTest.php M tests/phpunit/HashableObjectStorageTest.php M tests/phpunit/SimpleSiteLinkTest.php M tests/phpunit/Snak/PropertyValueSnakTest.php M tests/phpunit/hasharray/HashArrayTest.php M tests/phpunit/hasharray/HashArrayWithDuplicatesTest.php 18 files changed, 11 insertions(+), 26 deletions(-) Approvals: Daniel Kinzler: Looks good to me, approved jenkins-bot: Verified diff --git a/DataModel/Claim/ClaimGuid.php b/DataModel/Claim/ClaimGuid.php index dc4dd63..8753bf7 100644 --- a/DataModel/Claim/ClaimGuid.php +++ b/DataModel/Claim/ClaimGuid.php @@ -3,7 +3,6 @@ namespace Wikibase\DataModel\Claim; use Comparable; -use Wikibase\DataModel\Entity\BasicEntityIdParser; use Wikibase\DataModel\Entity\EntityId; /** diff --git a/DataModel/Claim/ClaimGuidParser.php b/DataModel/Claim/ClaimGuidParser.php index 7363fcc..5797f93 100644 --- a/DataModel/Claim/ClaimGuidParser.php +++ b/DataModel/Claim/ClaimGuidParser.php @@ -2,9 +2,6 @@ namespace Wikibase\DataModel\Claim; -use Wikibase\DataModel\Claim\ClaimGuid; -use Wikibase\DataModel\Claim\ClaimGuidParsingException; -use Wikibase\DataModel\Entity\BasicEntityIdParser; use Wikibase\DataModel\Entity\DispatchingEntityIdParser; use Wikibase\DataModel\Entity\EntityIdParser; diff --git a/DataModel/Entity/Entity.php b/DataModel/Entity/Entity.php index 7b7d88e..2fa7890 100644 --- a/DataModel/Entity/Entity.php +++ b/DataModel/Entity/Entity.php @@ -8,11 +8,9 @@ use Diff\Patcher; use InvalidArgumentException; use RuntimeException; -use Wikibase\DataModel\Entity\BasicEntityIdParser; +use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Internal\LegacyIdInterpreter; use Wikibase\DataModel\Internal\ObjectComparer; -use Wikibase\Lib\GuidGenerator; -use Wikibase\DataModel\Entity\EntityId; /** * Represents a single Wikibase entity. diff --git a/DataModel/Entity/EntityIdValue.php b/DataModel/Entity/EntityIdValue.php index 66d7c1e..a88c469 100644 --- a/DataModel/Entity/EntityIdValue.php +++ b/DataModel/Entity/EntityIdValue.php @@ -2,9 +2,9 @@ namespace Wikibase\DataModel\Entity; +use DataValues\DataValue; use DataValues\DataValueObject; use DataValues\IllegalValueException; -use DataValues\DataValue; use Wikibase\DataModel\Internal\LegacyIdInterpreter; /** diff --git a/DataModel/ItemDiff.php b/DataModel/ItemDiff.php index 746fa7f..2c8fb72 100644 --- a/DataModel/ItemDiff.php +++ b/DataModel/ItemDiff.php @@ -3,7 +3,6 @@ namespace Wikibase; use Diff\Diff; -use Diff\DiffOp; /** * Represents a diff between two Wikibase\Item instances. diff --git a/DataModel/MapValueHasher.php b/DataModel/MapValueHasher.php index 9e698ec..dcd01dc 100644 --- a/DataModel/MapValueHasher.php +++ b/DataModel/MapValueHasher.php @@ -2,9 +2,9 @@ namespace Wikibase; +use Hashable; use InvalidArgumentException; use Traversable; -use Hashable; /** * Generates hashes for associative arrays based on the values of their elements. diff --git a/DataModel/Snak/PropertyValueSnak.php b/DataModel/Snak/PropertyValueSnak.php index 8399a23..f7d1a7f 100644 --- a/DataModel/Snak/PropertyValueSnak.php +++ b/DataModel/Snak/PropertyValueSnak.php @@ -2,8 +2,8 @@ namespace Wikibase; -use DataValues\UnDeserializableValue; use DataValues\DataValue; +use DataValues\UnDeserializableValue; use Wikibase\DataModel\Entity\PropertyId; /** diff --git a/tests/phpunit/ByPropertyIdArrayTest.php b/tests/phpunit/ByPropertyIdArrayTest.php index 54843b4..c6512db 100644 --- a/tests/phpunit/ByPropertyIdArrayTest.php +++ b/tests/phpunit/ByPropertyIdArrayTest.php @@ -4,13 +4,12 @@ use DataValues\StringValue; use Wikibase\ByPropertyIdArray; -use Wikibase\DataModel\Entity\PropertyId; -use Wikibase\Property; -use Wikibase\Snak; use Wikibase\Claim; +use Wikibase\DataModel\Entity\PropertyId; use Wikibase\PropertyNoValueSnak; use Wikibase\PropertySomeValueSnak; use Wikibase\PropertyValueSnak; +use Wikibase\Snak; use Wikibase\Statement; /** diff --git a/tests/phpunit/Claim/ClaimGuidTest.php b/tests/phpunit/Claim/ClaimGuidTest.php index 9253344..a7da20c 100644 --- a/tests/phpunit/Claim/ClaimGuidTest.php +++ b/tests/phpunit/Claim/ClaimGuidTest.php @@ -4,10 +4,7 @@ use Exception; use Wikibase\DataModel\Claim\ClaimGuid; -use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\ItemId; -use Wikibase\Item; -use Wikibase\Property; /** * @covers Wikibase\DataModel\Claim\ClaimGuid diff --git a/tests/phpunit/Claim/ClaimsTest.php b/tests/phpunit/Claim/ClaimsTest.php index 292c973..e7ca3ef 100644 --- a/tests/phpunit/Claim/ClaimsTest.php +++ b/tests/phpunit/Claim/ClaimsTest.php @@ -11,7 +11,6 @@ use Wikibase\Claim; use Wikibase\Claims; use Wikibase\DataModel\Entity\PropertyId; -use Wikibase\Property; use Wikibase\PropertyNoValueSnak; use Wikibase\PropertySomeValueSnak; use Wikibase\PropertyValueSnak; diff --git a/tests/phpunit/Entity/EntityIdParserTest.php b/tests/phpunit/Entity/EntityIdParserTest.php index 5a5bae1..36cd97a 100644 --- a/tests/phpunit/Entity/EntityIdParserTest.php +++ b/tests/phpunit/Entity/EntityIdParserTest.php @@ -3,8 +3,8 @@ namespace Wikibase\Test; use Wikibase\DataModel\Entity\BasicEntityIdParser; -use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\DispatchingEntityIdParser; +use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\Entity\PropertyId; diff --git a/tests/phpunit/Entity/EntityTest.php b/tests/phpunit/Entity/EntityTest.php index 536dac8..f4ba0cf 100644 --- a/tests/phpunit/Entity/EntityTest.php +++ b/tests/phpunit/Entity/EntityTest.php @@ -14,7 +14,6 @@ use Wikibase\EntityDiff; use Wikibase\EntityId; use Wikibase\Item; -use Wikibase\Property; use Wikibase\PropertyNoValueSnak; use Wikibase\PropertySomeValueSnak; use Wikibase\PropertyValueSnak; diff --git a/tests/phpunit/Entity/ItemTest.php b/tests/phpunit/Entity/ItemTest.php index 0dba54d..574f1b4 100644 --- a/tests/phpunit/Entity/ItemTest.php +++ b/tests/phpunit/Entity/ItemTest.php @@ -15,7 +15,6 @@ use Wikibase\Entity; use Wikibase\Item; use Wikibase\ItemDiff; -use Wikibase\Property; use Wikibase\PropertyNoValueSnak; use Wikibase\PropertySomeValueSnak; use Wikibase\PropertyValueSnak; diff --git a/tests/phpunit/HashableObjectStorageTest.php b/tests/phpunit/HashableObjectStorageTest.php index ce2e9de..36d2ca5 100644 --- a/tests/phpunit/HashableObjectStorageTest.php +++ b/tests/phpunit/HashableObjectStorageTest.php @@ -2,8 +2,8 @@ namespace Wikibase\Test; -use Wikibase\HashableObjectStorage; use Wikibase\Hashable; +use Wikibase\HashableObjectStorage; /** * @covers Wikibase\HashableObjectStorage diff --git a/tests/phpunit/SimpleSiteLinkTest.php b/tests/phpunit/SimpleSiteLinkTest.php index 7c18428..2ebb17d 100644 --- a/tests/phpunit/SimpleSiteLinkTest.php +++ b/tests/phpunit/SimpleSiteLinkTest.php @@ -2,9 +2,9 @@ namespace Wikibase\DataModel\Test; -use Wikibase\DataModel\SimpleSiteLink; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\Entity\PropertyId; +use Wikibase\DataModel\SimpleSiteLink; /** * @covers Wikibase\DataModel\SimpleSiteLink diff --git a/tests/phpunit/Snak/PropertyValueSnakTest.php b/tests/phpunit/Snak/PropertyValueSnakTest.php index e79b019..710a473 100644 --- a/tests/phpunit/Snak/PropertyValueSnakTest.php +++ b/tests/phpunit/Snak/PropertyValueSnakTest.php @@ -6,7 +6,6 @@ use DataValues\UnDeserializableValue; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\Entity\PropertyId; -use Wikibase\Property; use Wikibase\PropertyValueSnak; /** diff --git a/tests/phpunit/hasharray/HashArrayTest.php b/tests/phpunit/hasharray/HashArrayTest.php index bffd404..866516e 100644 --- a/tests/phpunit/hasharray/HashArrayTest.php +++ b/tests/phpunit/hasharray/HashArrayTest.php @@ -2,8 +2,8 @@ namespace Wikibase\Test; -use Wikibase\HashArray; use Hashable; +use Wikibase\HashArray; /** * @covers Wikibase\HashArray diff --git a/tests/phpunit/hasharray/HashArrayWithDuplicatesTest.php b/tests/phpunit/hasharray/HashArrayWithDuplicatesTest.php index f62c94d..853ce1f 100644 --- a/tests/phpunit/hasharray/HashArrayWithDuplicatesTest.php +++ b/tests/phpunit/hasharray/HashArrayWithDuplicatesTest.php @@ -2,8 +2,8 @@ namespace Wikibase\Test; -use Wikibase\HashArray; use Hashable; +use Wikibase\HashArray; /** * @covers Wikibase\HashArray -- To view, visit https://gerrit.wikimedia.org/r/94917 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31e94a96c042de102b828fb5e34cadf19def513c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseDataModel Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
