Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/95350


Change subject: Remove Action class definition
......................................................................

Remove Action class definition

This removes compatibility for MediaWiki 1.17 and earlier versions.

Change-Id: Ib768be10b7fa8cc8d4a4438537100bba4ac51217
---
M INSTALL
M includes/SF_FormEditAction.php
M includes/SF_HelperFormAction.php
3 files changed, 1 insertion(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms 
refs/changes/50/95350/1

diff --git a/INSTALL b/INSTALL
index f5ad500..b4f7d7b 100644
--- a/INSTALL
+++ b/INSTALL
@@ -18,7 +18,7 @@
 == Requirements ==
 
 The extension requires an install of Semantic MediaWiki 1.6 or
-greater, as well as MediaWiki 1.17 or greater.
+greater, as well as MediaWiki 1.18 or greater.
 
 == Installation ==
 
diff --git a/includes/SF_FormEditAction.php b/includes/SF_FormEditAction.php
index a63ce5b..7cc8db3 100644
--- a/includes/SF_FormEditAction.php
+++ b/includes/SF_FormEditAction.php
@@ -7,11 +7,6 @@
  * @ingroup SF
  */
 
-// TODO: Action class did not exist until MW 1.18
-if ( ! class_exists( 'Action') ) {
-       class Action{}
-}
-
 class SFFormEditAction extends Action
 {
        /**
diff --git a/includes/SF_HelperFormAction.php b/includes/SF_HelperFormAction.php
index abf9a78..cab96eb 100644
--- a/includes/SF_HelperFormAction.php
+++ b/includes/SF_HelperFormAction.php
@@ -8,11 +8,6 @@
  * @ingroup SF
  */
 
-// TODO: Action class did not exist until MW 1.18
-if ( ! class_exists( 'Action') ) {
-       class Action{}
-}
-
 class SFHelperFormAction extends Action 
 {
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/95350
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib768be10b7fa8cc8d4a4438537100bba4ac51217
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to