Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95354
Change subject: Update docs
......................................................................
Update docs
Change-Id: I99655ad3df4bc252e3c176e4f465f5ecd615c55f
---
M includes/actions/CreditsAction.php
M includes/actions/HistoryAction.php
M includes/actions/InfoAction.php
M includes/actions/RevertAction.php
4 files changed, 33 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/54/95354/1
diff --git a/includes/actions/CreditsAction.php
b/includes/actions/CreditsAction.php
index cd7eb45..97c1605 100644
--- a/includes/actions/CreditsAction.php
+++ b/includes/actions/CreditsAction.php
@@ -127,6 +127,7 @@
$anon_ips = array();
# Sift for real versus user names
+ /** @var $user User */
foreach ( $contributors as $user ) {
$cnt--;
if ( $user->isLoggedIn() ) {
diff --git a/includes/actions/HistoryAction.php
b/includes/actions/HistoryAction.php
index 687a460..e6f22e4 100644
--- a/includes/actions/HistoryAction.php
+++ b/includes/actions/HistoryAction.php
@@ -37,6 +37,9 @@
const DIR_PREV = 0;
const DIR_NEXT = 1;
+ /** @var array Array of message keys and strings */
+ public $message;
+
public function getName() {
return 'history';
}
@@ -341,14 +344,28 @@
* @ingroup Actions
*/
class HistoryPager extends ReverseChronologicalPager {
- public $lastRow = false, $counter, $historyPage, $buttons, $conds;
+ /**
+ * @var bool|Object
+ */
+ public $lastRow = false;
+
+ public $counter, $historyPage, $buttons, $conds;
+
protected $oldIdChecked;
+
protected $preventClickjacking = false;
/**
* @var array
*/
protected $parentLens;
+ /**
+ * @param HistoryAction $historyPage
+ * @param string $year
+ * @param string $month
+ * @param string $tagFilter
+ * @param array $conds
+ */
function __construct( $historyPage, $year = '', $month = '', $tagFilter
= '', $conds = array() ) {
parent::__construct( $historyPage->getContext() );
$this->historyPage = $historyPage;
@@ -397,6 +414,10 @@
return 'rev_timestamp';
}
+ /**
+ * @param Object $row
+ * @return string
+ */
function formatRow( $row ) {
if ( $this->lastRow ) {
$latest = ( $this->counter == 1 && $this->mIsFirst );
@@ -537,14 +558,14 @@
*
* @todo document some more, and maybe clean up the code (some params
redundant?)
*
- * @param $row Object: the database row corresponding to the previous
line.
- * @param $next Mixed: the database row corresponding to the next line
+ * @param object $row The database row corresponding to the previous
line.
+ * @param mixed $next The database row corresponding to the next line
* (chronologically previous)
- * @param $notificationtimestamp
- * @param $latest Boolean: whether this row corresponds to the page's
latest revision.
- * @param $firstInList Boolean: whether this row corresponds to the
first
+ * @param bool|string $notificationtimestamp
+ * @param bool $latest Whether this row corresponds to the page's
latest revision.
+ * @param bool $firstInList Whether this row corresponds to the first
* displayed on this history page.
- * @return String: HTML output for the row
+ * @return string HTML output for the row
*/
function historyLine( $row, $next, $notificationtimestamp = false,
$latest = false, $firstInList = false ) {
diff --git a/includes/actions/InfoAction.php b/includes/actions/InfoAction.php
index c97267b..811e35d 100644
--- a/includes/actions/InfoAction.php
+++ b/includes/actions/InfoAction.php
@@ -763,6 +763,7 @@
$anon_ips = array();
# Sift for real versus user names
+ /** @var $user User */
foreach ( $contributors as $user ) {
$page = $user->isAnon()
? SpecialPage::getTitleFor( 'Contributions',
$user->getName() )
diff --git a/includes/actions/RevertAction.php
b/includes/actions/RevertAction.php
index e5f1929..cdd139e 100644
--- a/includes/actions/RevertAction.php
+++ b/includes/actions/RevertAction.php
@@ -48,6 +48,9 @@
* @ingroup Actions
*/
class RevertFileAction extends FormAction {
+ /**
+ * @var OldLocalFile
+ */
protected $oldFile;
public function getName() {
--
To view, visit https://gerrit.wikimedia.org/r/95354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99655ad3df4bc252e3c176e4f465f5ecd615c55f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
