Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95351
Change subject: Remove Action class definition
......................................................................
Remove Action class definition
This removes compatibility for MediaWiki 1.17 and earlier versions.
Change-Id: I5671a5d5080e68e0cab147696755b0b52fb3d989
---
M INSTALL
M includes/SD_HelperFormAction.php
2 files changed, 4 insertions(+), 9 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticDrilldown
refs/changes/51/95351/1
diff --git a/INSTALL b/INSTALL
index 0b90f4e..d984b54 100644
--- a/INSTALL
+++ b/INSTALL
@@ -12,9 +12,9 @@
== Requirements ==
-The extension requires an install of Semantic MediaWiki 1.5 or
-greater. For more details, see Semantic MediaWiki's own
-installation requirements.
+The extension requires an install of Semantic MediaWiki 1.5 or greater as
+well as MediaWiki 1.18 or greater. For more details, see Semantic
+MediaWiki's own installation requirements.
== Installation ==
diff --git a/includes/SD_HelperFormAction.php b/includes/SD_HelperFormAction.php
index 892cf02..1c0bf04 100644
--- a/includes/SD_HelperFormAction.php
+++ b/includes/SD_HelperFormAction.php
@@ -10,12 +10,7 @@
* @ingroup SD
*/
-// TODO: Action class did not exist until MW 1.18
-if ( ! class_exists( 'Action') ) {
- class Action{}
-}
-
-class SDHelperFormAction extends Action
+class SDHelperFormAction extends Action
{
/**
* Return the name of the action this object responds to
--
To view, visit https://gerrit.wikimedia.org/r/95351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5671a5d5080e68e0cab147696755b0b52fb3d989
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticDrilldown
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
