Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95452
Change subject: Hygiene: Cleanup enwp.less prepare to destroy it
......................................................................
Hygiene: Cleanup enwp.less prepare to destroy it
* .navbox is display:none in hacks.less yet there are loads of rules
in enwp.less that style it. Thus removing.
* other things are hidden in hacks.less so moving other display:none
rules from enwp.less there
* add FIXME to destroy enwp.less - originally it was designed to be
for enwiki specific styles but now we have Mobile.css and hacks.less
this has become confusing and redundant
Change-Id: I3eb546c869ff5db25f1ee0e8843149103302668e
---
M less/common/enwp.less
M less/common/hacks.less
2 files changed, 7 insertions(+), 60 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/52/95452/1
diff --git a/less/common/enwp.less b/less/common/enwp.less
index d38fa49..821b213 100644
--- a/less/common/enwp.less
+++ b/less/common/enwp.less
@@ -3,13 +3,9 @@
This file should not need to exist
IMPORTANT: do not use selectors containing attribute notation e.g. [style]
[colspan]
as they are known to damage the ios app
+FIXME: Kill this file
*/
@import "../variables.less";
-
-// Hide cleanup templates by default to non-javascript users as these stop
them from reading the article itself
-#content table.ambox {
- display: none;
-}
code,
pre {
@@ -22,40 +18,8 @@
padding: 1em;
}
-.mobile #coordinates {
- display: none; /* TODO: style for mobile */
-}
-
.dablink {
margin-bottom: 10px;
-}
-
-table.navbox td.navbox-group {
- background: #ddddff;
- width: 25%;
- padding: 3px;
-}
-
-table.navbox th.navbox-title {
- background: #ccccff;
- padding: 5px;
-}
-
-table.navbox td.navbox-abovebelow {
- padding: 3px;
-}
-
-table.navbox td.navbox-group + td {
- padding: 3px;
-}
-
-table.navbox td,
-table.navbox th {
- padding: 0;
-}
-
-table.navbox table {
- margin-bottom: 0;
}
table.infobox {
@@ -71,13 +35,6 @@
border: 0;
}
-.navbox .hlist dd,
-.navbox .hlist dt,
-.navbox .hlist li {
- white-space: pre-wrap !important;
- word-wrap: break-word;
-}
-
/* force portals to use a one column layout on mobile */
.mobile .portal-column-left-wide,
.mobile .portal-column-left,
@@ -89,21 +46,6 @@
.collapsible td {
width: auto !important;
-}
-
-table.navbox {
- font-size: 0.9em;
- width: 100% !important;
-}
-
-table.navbox div {
- padding-left: 0 !important;
- padding-right: 0 !important;
-}
-
-table.navbox div a,
-table.navbox span {
- white-space: pre-wrap !important;
}
table.infobox {
diff --git a/less/common/hacks.less b/less/common/hacks.less
index 2640140..bf75a94 100644
--- a/less/common/hacks.less
+++ b/less/common/hacks.less
@@ -48,9 +48,14 @@
/* Hide some on-wiki defined classes */
#content {
+ // Hide cleanup templates by default to non-javascript users as these
stop them from reading the article itself
+ // Note not in issues.less as that is only loaded via JavaScript
+ .ambox,
+ #coordinates,
// Hide article badges, clean-up notices, stub notices, and navigation
boxes
.navbox, .vertical-navbox, .topicon, .metadata {
- display: none;
+ // It's important as some of these are tables which become
display: table on larger screens
+ display: none !important;
}
}
/* Revert to showing nav boxes on tablet/desktop */
--
To view, visit https://gerrit.wikimedia.org/r/95452
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eb546c869ff5db25f1ee0e8843149103302668e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
