Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95519
Change subject: Avoid extra parsing in prepareContentForEdit()
......................................................................
Avoid extra parsing in prepareContentForEdit()
* WikiPage::clear() no longer resets mPreparedEdit
* Also actually made mPreparedEdit protected
Change-Id: I2c34baaf8b64b204444efa1bfa6ea356e0124c54
---
M includes/WikiPage.php
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/19/95519/1
diff --git a/includes/WikiPage.php b/includes/WikiPage.php
index 576979c..1cc586c 100644
--- a/includes/WikiPage.php
+++ b/includes/WikiPage.php
@@ -48,8 +48,10 @@
public $mDataLoaded = false; // !< Boolean
public $mIsRedirect = false; // !< Boolean
public $mLatest = false; // !< Integer (false means "not
loaded")
- public $mPreparedEdit = false; // !< Array
/**@}}*/
+
+ /** @var stdclass Map of cache fields (text, parser output, ect) for a
proposed/new edit */
+ protected $mPreparedEdit = false;
/**
* @var int
@@ -242,7 +244,9 @@
$this->mTimestamp = '';
$this->mIsRedirect = false;
$this->mLatest = false;
- $this->mPreparedEdit = false;
+ // Bug 57026: do not clear mPreparedEdit since
prepareTextForEdit() already checks
+ // the requested rev ID against the cached one and revision
text is immutable.
+ // Clearing it can cause extra parses on edit for no reason.
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/95519
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c34baaf8b64b204444efa1bfa6ea356e0124c54
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
