Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95568
Change subject: Don't load beta features code on mobile.
......................................................................
Don't load beta features code on mobile.
hehe.
Change-Id: Icd1cd6e6e526068c93879e7bcffbc59d8c11aebd
---
M includes/MobileFrontend.hooks.php
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/68/95568/1
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index feb16a9..9ff0063 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -479,16 +479,15 @@
global $wgMFEnableXAnalyticsLogging;
wfProfileIn( __METHOD__ );
- if ( class_exists( 'BetaFeatures' ) &&
- BetaFeatures::isFeatureEnabled(
$out->getSkin()->getUser(), 'betafeatures-geonotahack' ) ) {
- // FIXME: Remove need for this module
- $out->addModules( array( 'mobile.bridge' ) );
- // FIXME: Find better way to deal with wgMFMode in
desktop (maybe standardise BetaFeatures to use the same variable)
- $out->addJsConfigVars( 'wgMFMode', 'desktop-beta' );
- }
-
$context = MobileContext::singleton();
if ( !$context->shouldDisplayMobileView() ) {
+ if ( class_exists( 'BetaFeatures' ) &&
+ BetaFeatures::isFeatureEnabled(
$out->getSkin()->getUser(), 'betafeatures-geonotahack' ) ) {
+ // FIXME: Remove need for this module
+ $out->addModules( array( 'mobile.bridge' ) );
+ // FIXME: Find better way to deal with wgMFMode
in desktop (maybe standardise BetaFeatures to use the same variable)
+ $out->addJsConfigVars( 'wgMFMode',
'desktop-beta' );
+ }
wfProfileOut( __METHOD__);
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/95568
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd1cd6e6e526068c93879e7bcffbc59d8c11aebd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
