Tim Starling has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/95579


Change subject: Improve redis connection error log
......................................................................

Improve redis connection error log

Include the server name in the log entry for exceptions thrown during
connect. We are logging a lot of these.

Change-Id: Ia3f775a9e22447efb067c3203a3b80c4385aa2c0
---
M includes/clientpool/RedisConnectionPool.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/79/95579/1

diff --git a/includes/clientpool/RedisConnectionPool.php 
b/includes/clientpool/RedisConnectionPool.php
index c8e98a7..5e57941 100644
--- a/includes/clientpool/RedisConnectionPool.php
+++ b/includes/clientpool/RedisConnectionPool.php
@@ -204,7 +204,7 @@
                        }
                } catch ( RedisException $e ) {
                        $this->downServers[$server] = time() + 
self::SERVER_DOWN_TTL;
-                       wfDebugLog( 'redis', "Redis exception: " . 
$e->getMessage() . "\n" );
+                       wfDebugLog( 'redis', "Redis exception connecting to 
$server: " . $e->getMessage() . "\n" );
                        return false;
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/95579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3f775a9e22447efb067c3203a3b80c4385aa2c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to