jenkins-bot has submitted this change and it was merged.
Change subject: Deprecate addButton and insertTags in mediawiki.action.edit
......................................................................
Deprecate addButton and insertTags in mediawiki.action.edit
In wikibits many global functions marked as deprecated,
does this also in mediawiki.action.edit.
Change-Id: I64fcb41bc7812ac1aebc75f4f866b4b07fb7dc8e
---
M RELEASE-NOTES-1.23
M resources/mediawiki.action/mediawiki.action.edit.js
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/RELEASE-NOTES-1.23 b/RELEASE-NOTES-1.23
index 8ef5acd..d7c252a 100644
--- a/RELEASE-NOTES-1.23
+++ b/RELEASE-NOTES-1.23
@@ -73,6 +73,8 @@
** The rc_type field of recentchanges will be deprecated in a future point
release.
* The global variable $wgArticle has been removed after a lengthy deprecation.
+* The global functions addButton and insertTags (for mw.toolbar.addButton and
+ mw.toolbar.insertTags) now emits mw.log.warn when accessed.
== Compatibility ==
diff --git a/resources/mediawiki.action/mediawiki.action.edit.js
b/resources/mediawiki.action/mediawiki.action.edit.js
index ba711aa..4639aee 100644
--- a/resources/mediawiki.action/mediawiki.action.edit.js
+++ b/resources/mediawiki.action/mediawiki.action.edit.js
@@ -130,8 +130,8 @@
};
// Legacy (for compatibility with the code previously in
skins/common.edit.js)
- window.addButton = toolbar.addButton;
- window.insertTags = toolbar.insertTags;
+ mw.log.deprecate( window, 'addButton', toolbar.addButton, 'Use
mw.toolbar.addButton instead' );
+ mw.log.deprecate( window, 'insertTags', toolbar.insertTags, 'Use
mw.toolbar.insertTags instead' );
// Explose API publicly
mw.toolbar = toolbar;
--
To view, visit https://gerrit.wikimedia.org/r/95764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64fcb41bc7812ac1aebc75f4f866b4b07fb7dc8e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
