Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/95786


Change subject: (Bug 57710) Handle AttributeError exception for BS tags
......................................................................

(Bug 57710) Handle AttributeError exception for BS tags

This is a temp bugfix to prevent bot from spamming traceback
error messages on page until the reason for this bug has been found.

Change-Id: If3ea370afb403efaaa28a523108643b63c8b77ff
---
M subster.py
1 file changed, 15 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat 
refs/changes/86/95786/1

diff --git a/subster.py b/subster.py
index bc8d45d..7c4beaa 100644
--- a/subster.py
+++ b/subster.py
@@ -477,12 +477,21 @@
 
             BS = BeautifulSoup.BeautifulSoup(external_buffer)
             for item in BS_tags:
-                external_data = eval('BS.%s' % item[1])
-                external_data = 
self._BS_regex_str%{'var1':value+'BS:'+item[1],'var2':value,'cont':external_data}
-                content = content.replace(item[0], external_data, 1)
-
-            if (content != prev_content):
-                substed_tags.append(value+'BS')
+                # TODO: Error found for
+                # item[1] =
+                # 
body.findAll('table')[11].tbody.contents[20].contents[3].contens[0]
+                try:
+                    external_data = eval('BS.%s' % item[1])
+                except AttributeError:
+                    pywikibot.output(u'Invalid item "%s"' % item[1])
+                else:
+                    external_data = self._BS_regex_str % {
+                        'var1': value + 'BS:' + item[1],
+                        'var2': value,
+                        'cont': external_data}
+                    content = content.replace(item[0], external_data, 1)
+                    if (content != prev_content):
+                        substed_tags.append(value+'BS')
 
         metadata['bot-timestamp'] = pywikibot.Timestamp.now().isoformat(' ')
 

-- 
To view, visit https://gerrit.wikimedia.org/r/95786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If3ea370afb403efaaa28a523108643b63c8b77ff
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to