Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/95794


Change subject: ContentHandler: TextContent::diff should compare to given 
object, not itself
......................................................................

ContentHandler: TextContent::diff should compare to given object, not itself

Not sure this is actually used anywhere which might be why this has gone 
unnoticed.

Change-Id: Ifa7a684fe98774cae546b385b09a950cfa7eff32
---
M includes/content/TextContent.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/94/95794/1

diff --git a/includes/content/TextContent.php b/includes/content/TextContent.php
index f66dacd..3c5e429 100644
--- a/includes/content/TextContent.php
+++ b/includes/content/TextContent.php
@@ -178,7 +178,7 @@
                }
 
                $otext = $this->getNativeData();
-               $ntext = $this->getNativeData();
+               $ntext = $that->getNativeData();
 
                # Note: Use native PHP diff, external engines don't give us 
abstract output
                $ota = explode( "\n", $lang->segmentForDiff( $otext ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/95794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa7a684fe98774cae546b385b09a950cfa7eff32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to