Tpt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95844
Change subject: Split EqualityTests inside of classes tests
......................................................................
Split EqualityTests inside of classes tests
Change-Id: Ie081b7f91f62fa52503304643a1f57324d9c9d6d
---
D wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/EqualityTests.java
M wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/PageTitleTests.java
M wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/SiteTests.java
3 files changed, 17 insertions(+), 23 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/44/95844/1
diff --git
a/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/EqualityTests.java
b/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/EqualityTests.java
deleted file mode 100644
index f2da0ef..0000000
--- a/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/EqualityTests.java
+++ /dev/null
@@ -1,23 +0,0 @@
-package org.wikimedia.wikipedia.test;
-
-import junit.framework.TestCase;
-import org.wikimedia.wikipedia.PageTitle;
-import org.wikimedia.wikipedia.Site;
-
-public class EqualityTests extends TestCase {
- public void testPageTitle() throws Exception {
- assertTrue(new PageTitle(null, "India", new
Site("en.wikipedia.org")).equals(new PageTitle(null, "India", new
Site("en.wikipedia.org"))));
- assertTrue(new PageTitle("Talk", "India", new
Site("en.wikipedia.org")).equals(new PageTitle("Talk", "India", new
Site("en.wikipedia.org"))));
-
- assertFalse(new PageTitle(null, "India", new
Site("ta.wikipedia.org")).equals(new PageTitle(null, "India", new
Site("en.wikipedia.org"))));
- assertFalse(new PageTitle("Talk", "India", new
Site("ta.wikipedia.org")).equals(new PageTitle("Talk", "India", new
Site("en.wikipedia.org"))));
- assertFalse(new PageTitle("Talk", "India", new
Site("ta.wikipedia.org")).equals("Something else"));
- }
-
- public void testSite() throws Exception {
- assertTrue(new Site("en.wikipedia.org").equals(new
Site("en.wikipedia.org")));
-
- assertFalse(new Site("ta.wikipedia.org").equals(new
Site("en.wikipedia.org")));
- assertFalse(new Site("ta.wikipedia.org").equals("ta.wikipedia.org"));
- }
-}
diff --git
a/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/PageTitleTests.java
b/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/PageTitleTests.java
index b4a70fd..f367466 100644
---
a/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/PageTitleTests.java
+++
b/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/PageTitleTests.java
@@ -5,6 +5,16 @@
import org.wikimedia.wikipedia.Site;
public class PageTitleTests extends TestCase {
+
+ public void testEquals() throws Exception {
+ assertTrue(new PageTitle(null, "India", new
Site("en.wikipedia.org")).equals(new PageTitle(null, "India", new
Site("en.wikipedia.org"))));
+ assertTrue(new PageTitle("Talk", "India", new
Site("en.wikipedia.org")).equals(new PageTitle("Talk", "India", new
Site("en.wikipedia.org"))));
+
+ assertFalse(new PageTitle(null, "India", new
Site("ta.wikipedia.org")).equals(new PageTitle(null, "India", new
Site("en.wikipedia.org"))));
+ assertFalse(new PageTitle("Talk", "India", new
Site("ta.wikipedia.org")).equals(new PageTitle("Talk", "India", new
Site("en.wikipedia.org"))));
+ assertFalse(new PageTitle("Talk", "India", new
Site("ta.wikipedia.org")).equals("Something else"));
+ }
+
public void testPrefixedText() throws Exception {
Site enwiki = new Site("en.wikipedia.org");
diff --git
a/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/SiteTests.java
b/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/SiteTests.java
index b536a62..ad8ed87 100644
--- a/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/SiteTests.java
+++ b/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/SiteTests.java
@@ -5,6 +5,13 @@
public class SiteTests extends TestCase {
+ public void testEquals() throws Exception {
+ assertTrue(new Site("en.wikipedia.org").equals(new
Site("en.wikipedia.org")));
+
+ assertFalse(new Site("ta.wikipedia.org").equals(new
Site("en.wikipedia.org")));
+ assertFalse(new Site("ta.wikipedia.org").equals("ta.wikipedia.org"));
+ }
+
public void testNormalization() throws Exception {
assertEquals(new Site("en.wikipedia.org"), new
Site("en.m.wikipedia.org"));
assertEquals("bm.wikipedia.org", (new
Site("bm.wikipedia.org")).getDomain());
--
To view, visit https://gerrit.wikimedia.org/r/95844
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie081b7f91f62fa52503304643a1f57324d9c9d6d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Tpt <thoma...@hotmail.fr>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
