jenkins-bot has submitted this change and it was merged.
Change subject: Simplify ApiUserRights::getUrUser()
......................................................................
Simplify ApiUserRights::getUrUser()
Remove unneeded else and local variable assignment.
Change-Id: I166d811b220e925be11da5c49b6fe55f0d8e71c8
---
M includes/api/ApiUserrights.php
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
IAlex: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/api/ApiUserrights.php b/includes/api/ApiUserrights.php
index 5e068cb..4664e1e 100644
--- a/includes/api/ApiUserrights.php
+++ b/includes/api/ApiUserrights.php
@@ -67,13 +67,11 @@
$status = $form->fetchUser( $params['user'] );
if ( !$status->isOK() ) {
$this->dieStatus( $status );
- } else {
- $user = $status->value;
}
- $this->mUser = $user;
+ $this->mUser = $status->value;
- return $user;
+ return $status->value;
}
public function mustBePosted() {
--
To view, visit https://gerrit.wikimedia.org/r/95882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I166d811b220e925be11da5c49b6fe55f0d8e71c8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: IAlex <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
