Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95954
Change subject: Declare visibility on class properties of LCStore* classes
......................................................................
Declare visibility on class properties of LCStore* classes
No direct references found in core or extensions outside of the classes
themselves. None of these are subclassed, so set all of them to private.
Change-Id: Id599c0830c1e6d3679c7ae55147f4444f8252987
---
M includes/cache/LocalisationCache.php
1 file changed, 11 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/54/95954/1
diff --git a/includes/cache/LocalisationCache.php
b/includes/cache/LocalisationCache.php
index 2c9d8ae..7d029bc 100644
--- a/includes/cache/LocalisationCache.php
+++ b/includes/cache/LocalisationCache.php
@@ -1022,8 +1022,8 @@
* (See ObjectCache.php)
*/
class LCStoreAccel implements LCStore {
- var $currentLang;
- var $keys;
+ private $currentLang;
+ private $keys;
public function __construct() {
$this->cache = wfGetCache( CACHE_ACCEL );
@@ -1071,15 +1071,15 @@
* This will work on any MediaWiki installation.
*/
class LCStoreDB implements LCStore {
- var $currentLang;
- var $writesDone = false;
+ private $currentLang;
+ private $writesDone = false;
/**
* @var DatabaseBase
*/
- var $dbw;
- var $batch;
- var $readOnly = false;
+ private $dbw;
+ private $batch;
+ private $readOnly = false;
public function get( $code, $key ) {
if ( $this->writesDone ) {
@@ -1174,7 +1174,10 @@
* See Cdb.php and http://cr.yp.to/cdb.html
*/
class LCStoreCDB implements LCStore {
- var $readers, $writer, $currentLang, $directory;
+ private $readers;
+ private $writer;
+ private $currentLang;
+ private $directory;
function __construct( $conf = array() ) {
global $wgCacheDirectory;
--
To view, visit https://gerrit.wikimedia.org/r/95954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id599c0830c1e6d3679c7ae55147f4444f8252987
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
