jenkins-bot has submitted this change and it was merged.
Change subject: Set visibility for class properties of DependencyWrapper
......................................................................
Set visibility for class properties of DependencyWrapper
Set to private. No subclassing and no uses outside of the class in core or
extensions.
Change-Id: If195d02b8ce853242312de7fb4bc7dc1cbe94365
---
M includes/cache/CacheDependency.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/cache/CacheDependency.php
b/includes/cache/CacheDependency.php
index 32bcdf7..57d9af8 100644
--- a/includes/cache/CacheDependency.php
+++ b/includes/cache/CacheDependency.php
@@ -28,8 +28,8 @@
* @ingroup Cache
*/
class DependencyWrapper {
- var $value;
- var $deps;
+ private $value;
+ private $deps;
/**
* Create an instance.
--
To view, visit https://gerrit.wikimedia.org/r/95981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If195d02b8ce853242312de7fb4bc7dc1cbe94365
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: IAlex <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits