jenkins-bot has submitted this change and it was merged.
Change subject: Set visibility on class properties for *Dependency classes
......................................................................
Set visibility on class properties for *Dependency classes
Set visibility to private for properties that are not referenced outside
of the class itself, and when the class is not currently being subclassed.
Change-Id: I427c6de5a0a29b43cff755db0eb8a750db620173
---
M includes/cache/CacheDependency.php
1 file changed, 12 insertions(+), 8 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/cache/CacheDependency.php
b/includes/cache/CacheDependency.php
index 57d9af8..27f136a 100644
--- a/includes/cache/CacheDependency.php
+++ b/includes/cache/CacheDependency.php
@@ -148,7 +148,8 @@
* @ingroup Cache
*/
class FileDependency extends CacheDependency {
- var $filename, $timestamp;
+ private $filename;
+ private $timestamp;
/**
* Create a file dependency
@@ -218,9 +219,10 @@
* @ingroup Cache
*/
class TitleDependency extends CacheDependency {
- var $titleObj;
- var $ns, $dbk;
- var $touched;
+ private $titleObj;
+ private $ns;
+ private $dbk;
+ private $touched;
/**
* Construct a title dependency
@@ -287,8 +289,8 @@
* @ingroup Cache
*/
class TitleListDependency extends CacheDependency {
- var $linkBatch;
- var $timestamps;
+ private $linkBatch;
+ private $timestamps;
/**
* Construct a dependency on a list of titles
@@ -393,7 +395,8 @@
* @ingroup Cache
*/
class GlobalDependency extends CacheDependency {
- var $name, $value;
+ private $name;
+ private $value;
function __construct( $name ) {
$this->name = $name;
@@ -415,7 +418,8 @@
* @ingroup Cache
*/
class ConstantDependency extends CacheDependency {
- var $name, $value;
+ private $name;
+ private $value;
function __construct( $name ) {
$this->name = $name;
--
To view, visit https://gerrit.wikimedia.org/r/95982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I427c6de5a0a29b43cff755db0eb8a750db620173
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: IAlex <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
