Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96082


Change subject: Make last modified bar green until page is >= 24 hours
......................................................................

Make last modified bar green until page is >= 24 hours

Bug: 56862
Change-Id: I1b30bf583b5f6b18030ceff11e47ed53ed46f83f
---
M javascripts/modules/lastEdited/lastEditedBeta.js
M javascripts/modules/lastEdited/time.js
2 files changed, 10 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/82/96082/1

diff --git a/javascripts/modules/lastEdited/lastEditedBeta.js 
b/javascripts/modules/lastEdited/lastEditedBeta.js
index 8dd8922..9040e39 100644
--- a/javascripts/modules/lastEdited/lastEditedBeta.js
+++ b/javascripts/modules/lastEdited/lastEditedBeta.js
@@ -32,12 +32,14 @@
                if ( ts ) {
                        delta = time.getTimeAgoDelta( parseInt( ts, 10 ) );
                        if ( time.isNow( delta ) ) {
-                               $lastModified.addClass( 'active' );
                                args = args.concat( [ 
'mobile-frontend-last-modified-with-user-just-now', gender, username ] );
                        } else {
                                args = args.concat( [ keys[ delta.unit ], 
gender, username,
                                                mw.language.convertNumber( 
delta.value ) ] );
                        }
+                       if ( time.isRecent( delta ) ) {
+                               $lastModified.addClass( 'active' );
+                       }
 
                        args = args.concat( [ historyUrl,
                                        // Abuse PLURAL support to determine if 
the user is anonymous or not
diff --git a/javascripts/modules/lastEdited/time.js 
b/javascripts/modules/lastEdited/time.js
index 4d40741..e05dc58 100644
--- a/javascripts/modules/lastEdited/time.js
+++ b/javascripts/modules/lastEdited/time.js
@@ -16,13 +16,19 @@
                return delta;
        }
 
+       function isRecent( delta ) {
+               var u = delta.unit;
+               return [ 'seconds', 'minutes', 'hours' ].indexOf( u ) > - 1;
+       }
+
        function isNow( delta ) {
                return delta.unit === 'seconds' && delta.value < 10;
        }
 
        M.define( 'modules/lastEdited/time', {
                getTimeAgoDelta: getTimeAgoDelta,
-               isNow: isNow
+               isNow: isNow,
+               isRecent: isRecent
        } );
 
 }( mw.mobileFrontend ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/96082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b30bf583b5f6b18030ceff11e47ed53ed46f83f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to