Jhall has uploaded a new change for review.
https://gerrit.wikimedia.org/r/96083
Change subject: Adding Review Changes workflow per reviewer comment
......................................................................
Adding Review Changes workflow per reviewer comment
Change-Id: I50d0defb3c4f51f317a497d0f805859e961b8f7f
---
M modules/ve-mw/test/browser/features/computer_code.feature
M modules/ve-mw/test/browser/features/step_definitions/computer_code_steps.rb
M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
3 files changed, 8 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/83/96083/1
diff --git a/modules/ve-mw/test/browser/features/computer_code.feature
b/modules/ve-mw/test/browser/features/computer_code.feature
index 6c78b92..e2fb39c 100644
--- a/modules/ve-mw/test/browser/features/computer_code.feature
+++ b/modules/ve-mw/test/browser/features/computer_code.feature
@@ -3,9 +3,12 @@
Scenario: VisualEditor Computer Code
Given I am logged in
- And I am at my user page
+ And I am at my user page
When I click Edit for VisualEditor
- And I type in an input string
- And select the string
- And I click Computer Code
- Then computer code styling should be visible
\ No newline at end of file
+ And I type in an input string
+ And select the string
+ And I click Computer Code
+ And I click Save page
+ And I click Review your changes
+ Then <code>This is a new line</code> should appear in the diff view
+ And I can click the X on the save box
diff --git
a/modules/ve-mw/test/browser/features/step_definitions/computer_code_steps.rb
b/modules/ve-mw/test/browser/features/step_definitions/computer_code_steps.rb
index 75ac1e9..a1e7f5b 100644
---
a/modules/ve-mw/test/browser/features/step_definitions/computer_code_steps.rb
+++
b/modules/ve-mw/test/browser/features/step_definitions/computer_code_steps.rb
@@ -3,8 +3,4 @@
page.more_menu_element.when_present.click
page.ve_computer_code_element.when_present.click
end
-end
-
-Then(/^computer code styling should be visible$/) do
- on(VisualEditorPage).ve_computer_code_annotation_element.should be_visible
end
\ No newline at end of file
diff --git
a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
index 216a768..d80c541 100644
--- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
@@ -33,7 +33,6 @@
span(:subheading4, text: 'Sub-heading 4')
span(:ve_bullets, class: 'oo-ui-iconedElement-icon oo-ui-icon-bullet-list')
span(:ve_computer_code, class: 'oo-ui-iconedElement-icon oo-ui-icon-code')
- code(:ve_computer_code_annotation, class: 've-ce-TextStyleAnnotation
ve-ce-TextStyleCodeAnnotation')
div(:ve_heading_menu, class: 'oo-ui-iconedElement-icon oo-ui-icon-down')
span(:ve_link_icon, class: 'oo-ui-iconedElement-icon oo-ui-icon-link')
span(:ve_references, class: 'oo-ui-iconedElement-icon oo-ui-icon-reference')
--
To view, visit https://gerrit.wikimedia.org/r/96083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50d0defb3c4f51f317a497d0f805859e961b8f7f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jhall <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
