Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/96150
Change subject: Put status handling in EditPage into private function
......................................................................
Put status handling in EditPage into private function
This bit of code is isolated enough to be separated from
attemptSave and be put into a private function.
Change-Id: I84c532358ee32fec959039c62798e4de0702f14a
---
M includes/EditPage.php
1 file changed, 18 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/50/96150/3
diff --git a/includes/EditPage.php b/includes/EditPage.php
index 9a68ab3..e4fa6c9 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -1204,13 +1204,29 @@
* @throws
UserBlockedError|ReadOnlyError|ThrottledError|PermissionsError
* @return bool false if output is done, true if the rest of the form
should be displayed
*/
- function attemptSave() {
- global $wgUser, $wgOut;
+ public function attemptSave() {
+ global $wgUser;
$resultDetails = false;
# Allow bots to exempt some edits from bot flagging
$bot = $wgUser->isAllowed( 'bot' ) && $this->bot;
$status = $this->internalAttemptSave( $resultDetails, $bot );
+
+ return $this->handleStatus( $status, $resultDetails );
+ }
+
+ /**
+ * Handle status, such as after attempt save
+ *
+ * @param Status $status
+ * @param array|bool $resultDetails
+ *
+ * @throws
UserBlockedError|ReadOnlyError|ThrottledError|PermissionsError
+ * return bool false, if output is done, true if rest of the form
should be displayed
+ */
+ private function handleStatus( Status $status, $resultDetails ) {
+ global $wgUser, $wgOut;
+
// FIXME: once the interface for internalAttemptSave() is made
nicer, this should use the message in $status
if ( $status->value == self::AS_SUCCESS_UPDATE ||
$status->value == self::AS_SUCCESS_NEW_ARTICLE ) {
$this->didSave = true;
--
To view, visit https://gerrit.wikimedia.org/r/96150
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84c532358ee32fec959039c62798e4de0702f14a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
