Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/96220
Change subject: Declare visibility on class properties of RecentChange
......................................................................
Declare visibility on class properties of RecentChange
All are referenced directly outside inheritence; declare all public.
Removed unused $mMovedToTitle.
Change-Id: I3ba8f377e1a1082d3a2bb4b043e10bc351c0b5dd
---
M includes/changes/RecentChange.php
1 file changed, 5 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/20/96220/1
diff --git a/includes/changes/RecentChange.php
b/includes/changes/RecentChange.php
index a6920f6..d153212 100644
--- a/includes/changes/RecentChange.php
+++ b/includes/changes/RecentChange.php
@@ -64,7 +64,6 @@
* @todo document functions and variables
*/
class RecentChange {
-
// Constants for the rc_source field. Extensions may also have
// their own source constants.
const SRC_EDIT = 'mw.edit';
@@ -72,24 +71,21 @@
const SRC_LOG = 'mw.log';
const SRC_EXTERNAL = 'mw.external'; // obsolete
- var $mAttribs = array(), $mExtra = array();
+ public $mAttribs = array();
+ public $mExtra = array();
/**
* @var Title
*/
- var $mTitle = false;
+ public $mTitle = false;
/**
* @var User
*/
private $mPerformer = false;
- /**
- * @var Title
- */
- var $mMovedToTitle = false;
- var $numberofWatchingusers = 0; # Dummy to prevent error message in
SpecialRecentchangeslinked
- var $notificationtimestamp;
+ public $numberofWatchingusers = 0; # Dummy to prevent error message in
SpecialRecentchangeslinked
+ public $notificationtimestamp;
# Factory methods
--
To view, visit https://gerrit.wikimedia.org/r/96220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ba8f377e1a1082d3a2bb4b043e10bc351c0b5dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
