jenkins-bot has submitted this change and it was merged. Change subject: [Browser test] Add Review Changes workflow per reviewer comment ......................................................................
[Browser test] Add Review Changes workflow per reviewer comment Change-Id: I50d0defb3c4f51f317a497d0f805859e961b8f7f --- A modules/ve-mw/test/browser/features/computer_code.feature A modules/ve-mw/test/browser/features/step_definitions/computer_code_steps.rb M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb 3 files changed, 21 insertions(+), 0 deletions(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/test/browser/features/computer_code.feature b/modules/ve-mw/test/browser/features/computer_code.feature new file mode 100644 index 0000000..e2fb39c --- /dev/null +++ b/modules/ve-mw/test/browser/features/computer_code.feature @@ -0,0 +1,14 @@ +@ie6-bug @ie7-bug @ie8-bug @ie9-bug @ie10-bug @en.wikipedia.beta.wmflabs.org @test2.wikipedia.org @login +Feature: VisualEditor Computer Code + + Scenario: VisualEditor Computer Code + Given I am logged in + And I am at my user page + When I click Edit for VisualEditor + And I type in an input string + And select the string + And I click Computer Code + And I click Save page + And I click Review your changes + Then <code>This is a new line</code> should appear in the diff view + And I can click the X on the save box diff --git a/modules/ve-mw/test/browser/features/step_definitions/computer_code_steps.rb b/modules/ve-mw/test/browser/features/step_definitions/computer_code_steps.rb new file mode 100644 index 0000000..8d1a9be --- /dev/null +++ b/modules/ve-mw/test/browser/features/step_definitions/computer_code_steps.rb @@ -0,0 +1,6 @@ +When(/^I click Computer Code$/) do + on(VisualEditorPage) do |page| + page.more_menu_element.when_present.click + page.ve_computer_code_element.when_present.click + end +end diff --git a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb index a1c186b..d80c541 100644 --- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb @@ -32,6 +32,7 @@ span(:subheading3, text: 'Sub-heading 3') span(:subheading4, text: 'Sub-heading 4') span(:ve_bullets, class: 'oo-ui-iconedElement-icon oo-ui-icon-bullet-list') + span(:ve_computer_code, class: 'oo-ui-iconedElement-icon oo-ui-icon-code') div(:ve_heading_menu, class: 'oo-ui-iconedElement-icon oo-ui-icon-down') span(:ve_link_icon, class: 'oo-ui-iconedElement-icon oo-ui-icon-link') span(:ve_references, class: 'oo-ui-iconedElement-icon oo-ui-icon-reference') -- To view, visit https://gerrit.wikimedia.org/r/96083 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50d0defb3c4f51f317a497d0f805859e961b8f7f Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jhall <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Jforrester <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
