Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/96229
Change subject: Remove use of global, which causes test failure for non-english
wikis
......................................................................
Remove use of global, which causes test failure for non-english wikis
Change-Id: Ic27737f896f6d13cd42a515837725b0dfbcced12
---
M repo/includes/SummaryFormatter.php
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/29/96229/1
diff --git a/repo/includes/SummaryFormatter.php
b/repo/includes/SummaryFormatter.php
index 9c8815c..9475444 100644
--- a/repo/includes/SummaryFormatter.php
+++ b/repo/includes/SummaryFormatter.php
@@ -231,7 +231,6 @@
* @return string to be used for the summary
*/
private function assembleSummaryString( $comment, $summary, $length =
SUMMARY_MAX_LENGTH ) {
- global $wgContLang;
$normalizer =
WikibaseRepo::getDefaultInstance()->getStringNormalizer();
$comment = $normalizer->trimToNFC( $comment );
@@ -241,7 +240,7 @@
$mergedString .= "/* $comment */";
}
if ( $summary !== "" ) {
- $mergedString .= $wgContLang->truncate( $summary,
$length - strlen( $mergedString ) );
+ $mergedString .= $this->language->truncate( $summary,
$length - strlen( $mergedString ) );
}
// leftover entities should be removed, but its not clear how
this shall be done
--
To view, visit https://gerrit.wikimedia.org/r/96229
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic27737f896f6d13cd42a515837725b0dfbcced12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
