Hey guys, See this note from Katie. Summary:
1) PCI compliance says that the code they deploy to the payments cluster must have peer-review. 2) There are 35 commits to core that are self-merged with no review (see Elliot's script). Retroactively +1ing the changes is probably sufficient (after you've reviewed the change, of course :) ). Deadline appears to be "before November". Help? Greg PS: Katie is cc'd, but I don't think she is on ourlist. ---------- Forwarded message ---------- From: Katie Horn <[email protected]> Date: Tue, Oct 14, 2014 at 3:59 PM Subject: Self-reviews in core between 1.22 and 1.23 To: Greg Grossmeier <[email protected]> Hey Greg, Thanks for looking in to this. Elliott came up with the following awk script and its subsequent output, both attached. To summarize: PCI rules say that we can not deploy code to payments systems if there were any unreviewed (self-merged) patches, and we found about 35 in the upgrade of mediawiki core that fundraising would like to do before November. It should be sufficient to have somebody other than the original committer retroactively +1 the patch in gerrit. Just so I can prove everything had extra eyes on it before we deploy the code to payments. Please let me know if something went wrong with the attachments, and I will gladly resend. Thanks! -Katie ---------- Forwarded message ---------- From: Elliott Eggleston <[email protected]> Date: Tue, Oct 14, 2014 at 3:48 PM Subject: Fwd: Fwd: For your inner PCI lawyer To: Katie Horn <[email protected]> Do this log command and the attached awk script look correct? git log --no-merges --show-notes=review --name-status fundraising/REL1_22..REL1_23 -- *php *php5 skins resources includes > allLog ./findSelfMerge.awk < allLog > unreviewed.txt -- Greg Grossmeier Release Team Manager
Unreviewed commit: 8ad118d2fca5f39ada5b08aaecbb57874d02dfc0 Author: Bartosz DziewoÅski <[email protected]> Date: Sat May 17 15:46:23 2014 +0200 https://gerrit.wikimedia.org/r/134070 skins/vector/components/watchstar.less Unreviewed commit: d37e8e1e690a69f746ebd0a54988f75a00bbd4ea Author: Bartosz DziewoÅski <[email protected]> Date: Tue Apr 29 10:37:46 2014 +0200 https://gerrit.wikimedia.org/r/131101 includes/installer/WebInstallerOutput.php resources/Resources.php skins/MonoBook.php skins/Vector.php Unreviewed commit: b796214bf8a55bc6f10e4f9bcf4692f6fd6995f0 Author: Bartosz DziewoÅski <[email protected]> Date: Tue Apr 29 20:20:32 2014 +0200 https://gerrit.wikimedia.org/r/130420 skins/common/wikibits.js Unreviewed commit: 91a95a85240f71642350d9b55bbaa4061405251c Author: Bartosz DziewoÅski <[email protected]> Date: Thu Apr 17 21:08:50 2014 +0200 https://gerrit.wikimedia.org/r/130403 includes/UserMailer.php Unreviewed commit: c53c4295d5aa5199585f897b9ddd15d5464d872a Author: Bartosz DziewoÅski <[email protected]> Date: Fri Apr 18 22:07:32 2014 +0200 https://gerrit.wikimedia.org/r/127471 resources/src/jquery/jquery.suggestions.js Unreviewed commit: 615776812af78975a6c475445de491c78596b241 Author: Bartosz DziewoÅski <[email protected]> Date: Tue Mar 4 21:32:19 2014 +0100 https://gerrit.wikimedia.org/r/116790 resources/src/mediawiki.special/mediawiki.special.css Unreviewed commit: 3a4e66ca92750a81ad196f16c4806c154bd6ce3f Author: Aaron Schulz <[email protected]> Date: Mon Apr 7 16:07:55 2014 -0700 https://gerrit.wikimedia.org/r/124490 includes/utils/UIDGenerator.php Unreviewed commit: 4e2f7855284ee28ba6b85c88169ca27710eb790f Author: Aaron Schulz <[email protected]> Date: Thu Feb 27 21:48:14 2014 -0800 https://gerrit.wikimedia.org/r/116060 includes/job/JobQueue.php Unreviewed commit: 2ae43d26412960d4072ebd274a63ccbeb9b445d7 Author: Bartosz DziewoÅski <[email protected]> Date: Wed Feb 19 18:09:26 2014 +0100 https://gerrit.wikimedia.org/r/114162 resources/mediawiki.less/mediawiki.mixins.less Unreviewed commit: 3ce18f0fb27e505a975d8d8817ce507413c84b3a Author: Bartosz DziewoÅski <[email protected]> Date: Tue Feb 11 16:07:06 2014 +0100 https://gerrit.wikimedia.org/r/112694 skins/vector/variables.less Unreviewed commit: fa02cc683ddaf2c2a5df04ad8587366aacc20ce0 Author: Bartosz DziewoÅski <[email protected]> Date: Tue Feb 11 16:06:17 2014 +0100 https://gerrit.wikimedia.org/r/112693 skins/vector/components/tabs.less Unreviewed commit: e56e3ce5e9273def9abbeebbccc79ed1d5bd7ffa Author: Chad <[email protected]> Date: Tue Feb 11 01:03:45 2014 +0000 https://gerrit.wikimedia.org/r/112615 includes/WebRequest.php includes/specials/SpecialSearch.php Unreviewed commit: 967dd32d071b28a706838c82d1098449d022757c Author: Hashar <[email protected]> Date: Thu Feb 6 09:04:46 2014 +0000 https://gerrit.wikimedia.org/r/111739 includes/Setup.php Unreviewed commit: c6da71b844650d3f671e087b72c95604e54a31fd Author: Bartosz DziewoÅski <[email protected]> Date: Tue Feb 4 20:42:08 2014 +0100 https://gerrit.wikimedia.org/r/82102 skins/vector/components/search.less Unreviewed commit: b1e41cf71861494f8da2580916808fcdd39c8aa7 Author: Ori.livneh <[email protected]> Date: Thu Jan 23 00:25:02 2014 +0000 https://gerrit.wikimedia.org/r/109018 resources/mediawiki/mediawiki.js Unreviewed commit: c745ff9a58e4ed6e5d380fc5113676d65f1594c4 Author: Aaron Schulz <[email protected]> Date: Thu Jan 9 12:39:13 2014 -0800 https://gerrit.wikimedia.org/r/106616 includes/filebackend/FileBackendStore.php Unreviewed commit: 472c27f8ca146fcb60da7c4e474e29c368b6a8d0 Author: Ori.livneh <[email protected]> Date: Fri Jan 3 23:53:11 2014 +0000 https://gerrit.wikimedia.org/r/105413 skins/common/images/feed-icon.svg skins/common/images/question.svg skins/vector/images/arrow-collapsed-ltr.svg skins/vector/images/arrow-collapsed-rtl.svg skins/vector/images/arrow-down-focus-icon.svg skins/vector/images/arrow-down-icon.svg skins/vector/images/arrow-expanded.svg skins/vector/images/audio-icon.svg skins/vector/images/document-icon.svg skins/vector/images/external-link-ltr-icon.svg skins/vector/images/external-link-rtl-icon.svg skins/vector/images/file-icon.svg skins/vector/images/lock-icon.svg skins/vector/images/mail-icon.svg skins/vector/images/news-icon.svg skins/vector/images/talk-icon.svg skins/vector/images/user-icon.svg skins/vector/images/video-icon.svg Unreviewed commit: fbe350750b79b5c0ec2fbf9b0fd1554399bb1c05 Author: Aaron Schulz <[email protected]> Date: Fri Dec 27 14:40:15 2013 -0800 https://gerrit.wikimedia.org/r/104151 includes/db/DatabaseMysqlBase.php includes/db/DatabaseMysqli.php Unreviewed commit: d0554cd5210c0e87ff5f9c77840af79541de4d5f Author: Reedy <[email protected]> Date: Mon Dec 30 18:11:07 2013 +0000 https://gerrit.wikimedia.org/r/104534 includes/actions/CreditsAction.php Unreviewed commit: 28252aae19a7d2d86a91e5bb6e96d8967b80bbf6 Author: Aaron Schulz <[email protected]> Date: Sun Dec 29 14:22:22 2013 -0800 https://gerrit.wikimedia.org/r/104479 includes/job/JobQueueFederated.php Unreviewed commit: bbebcb4bbf9f677e484df6269c4711f461b2203e Author: Bartosz DziewoÅski <[email protected]> Date: Fri Dec 27 21:23:20 2013 +0000 https://gerrit.wikimedia.org/r/104139 skins/.gitignore Unreviewed commit: 3dc25b783a570a319445c138ed05419e25cfdb89 Author: Aaron Schulz <[email protected]> Date: Thu Dec 5 21:35:56 2013 -0800 https://gerrit.wikimedia.org/r/99617 includes/job/jobs/HTMLCacheUpdateJob.php Unreviewed commit: 2f29c7551b3106f75eb4a3818c295e5ef9919a47 Author: Aaron Schulz <[email protected]> Date: Tue Dec 3 20:40:24 2013 +0000 https://gerrit.wikimedia.org/r/98902 includes/filebackend/FileBackend.php includes/filebackend/FileBackendGroup.php includes/filebackend/FileBackendMultiWrite.php Unreviewed commit: 9361f2cfd7ad1b6e65c58941b1a5187e83178651 Author: Aaron Schulz <[email protected]> Date: Tue Dec 3 08:56:48 2013 -0800 https://gerrit.wikimedia.org/r/98850 includes/job/jobs/RefreshLinksJob.php Unreviewed commit: 1f0475ae237b1bb5560c69d63ab6afc4de2f7b89 Author: Bartosz DziewoÅski <[email protected]> Date: Tue Dec 3 14:39:41 2013 +0100 https://gerrit.wikimedia.org/r/98809 resources/jquery/jquery.spinner.js Unreviewed commit: 7bd656365fc8c348869526dc6893c58dee5ef1aa Author: Aaron Schulz <[email protected]> Date: Sun Dec 1 23:09:06 2013 -0800 https://gerrit.wikimedia.org/r/98478 includes/job/JobQueueRedis.php Unreviewed commit: 489a33c6d32784f2988116daf995d7d31fd4c0ea Author: Bartosz DziewoÅski <[email protected]> Date: Sat Nov 23 16:31:07 2013 +0100 https://gerrit.wikimedia.org/r/97305 includes/Html.php Unreviewed commit: ee574b9c6aff00929b46e87dba6ddde2166a409f Author: Aaron Schulz <[email protected]> Date: Tue Nov 5 14:18:07 2013 -0800 https://gerrit.wikimedia.org/r/93866 includes/clientpool/RedisConnectionPool.php Unreviewed commit: beb73592433fe5197a24b6ec776dd57321b0e922 Author: Aaron Schulz <[email protected]> Date: Sat Nov 16 23:44:41 2013 -0800 https://gerrit.wikimedia.org/r/95843 includes/filebackend/FileBackendStore.php Unreviewed commit: c24f8be7299357c8cad9dd64519c1e42c2c0be00 Author: MarkAHershberger <[email protected]> Date: Sat Nov 16 02:06:01 2013 +0000 https://gerrit.wikimedia.org/r/95752 includes/AutoLoader.php includes/db/Database.php includes/db/DatabaseMssql.php includes/search/SearchMssql.php Unreviewed commit: 34a146c5f25424cee704e43347ec952c50253d67 Author: Bartosz DziewoÅski <[email protected]> Date: Fri Nov 15 22:31:43 2013 +0100 https://gerrit.wikimedia.org/r/95703 skins/common/commonPrint.css Unreviewed commit: e81c62ef3ec108584ab0ecf970b00165117e1df3 Author: Aaron Schulz <[email protected]> Date: Tue Nov 5 13:59:55 2013 -0800 https://gerrit.wikimedia.org/r/93862 includes/job/JobQueueRedis.php Unreviewed commit: 64d0dc06a036c38574877fe72f940c27cf172a90 Author: Tim Starling <[email protected]> Date: Fri Nov 1 15:59:17 2013 +1100 https://gerrit.wikimedia.org/r/93021 includes/AutoLoader.php includes/CallableUpdate.php includes/DataUpdate.php includes/DeferredUpdates.php includes/LinksUpdate.php includes/SiteStats.php includes/SqlDataUpdate.php includes/ViewCountUpdate.php includes/cache/HTMLCacheUpdate.php includes/cache/SquidUpdate.php includes/deferred/CallableUpdate.php includes/deferred/DataUpdate.php includes/deferred/DeferredUpdates.php includes/deferred/HTMLCacheUpdate.php includes/deferred/LinksUpdate.php includes/deferred/SearchUpdate.php includes/deferred/SiteStatsUpdate.php includes/deferred/SqlDataUpdate.php includes/deferred/SquidUpdate.php includes/deferred/ViewCountUpdate.php includes/search/SearchUpdate.php Unreviewed commit: bcdaf27eac106b22587c9c0abdd4d836f4d8863f Author: Tim Starling <[email protected]> Date: Wed Oct 23 16:58:29 2013 +1100 https://gerrit.wikimedia.org/r/91346 includes/parser/LinkHolderArray.php Unreviewed commit: 209cdf314c3d313c7a6fe0832749fe433063be00 Author: Reedy <[email protected]> Date: Thu Oct 24 18:13:19 2013 +0100 https://gerrit.wikimedia.org/r/91629 includes/DefaultSettings.php
findSelfMerge.awk
Description: application/awk
_______________________________________________ MediaWiki-Core mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-core
