Revision: 43465
Author: aaron
Date: 2008-11-13 23:18:01 +0000 (Thu, 13 Nov 2008)
Log Message:
-----------
Forgot to commit propchange class
Modified Paths:
--------------
trunk/extensions/CodeReview/CodeReview.php
trunk/extensions/CodeReview/CodeRevision.php
Added Paths:
-----------
trunk/extensions/CodeReview/CodePropChange.php
Added: trunk/extensions/CodeReview/CodePropChange.php
===================================================================
--- trunk/extensions/CodeReview/CodePropChange.php
(rev 0)
+++ trunk/extensions/CodeReview/CodePropChange.php 2008-11-13 23:18:01 UTC
(rev 43465)
@@ -0,0 +1,24 @@
+<?php
+if (!defined('MEDIAWIKI')) die();
+
+class CodePropChange {
+ function __construct( $rev ) {
+ $this->rev = $rev;
+ }
+
+ static function newFromRow( $rev, $row ) {
+ return self::newFromData( $rev, get_object_vars( $row ) );
+ }
+
+ static function newFromData( $rev, $data ) {
+ $change = new CodeComment( $rev );
+ $change->attrib = $data['cpc_attrib'];
+ $change->removed = $data['cpc_removed'];
+ $change->added = $data['cpc_added'];
+ $change->user = $data['cpc_user'];
+ // We'd prefer the up to date user table name
+ $change->userText = isset($data['user_name']) ?
$data['user_name'] : $data['cpc_user_text'];
+ $change->timestamp = wfTimestamp( TS_MW, $data['cpc_timestamp']
);
+ return $change;
+ }
+}
Property changes on: trunk/extensions/CodeReview/CodePropChange.php
___________________________________________________________________
Added: svn:eol-style
+ native
Modified: trunk/extensions/CodeReview/CodeReview.php
===================================================================
--- trunk/extensions/CodeReview/CodeReview.php 2008-11-13 23:10:34 UTC (rev
43464)
+++ trunk/extensions/CodeReview/CodeReview.php 2008-11-13 23:18:01 UTC (rev
43465)
@@ -58,6 +58,7 @@
$wgAutoloadClasses['CodeTagListView'] = $dir . 'CodeTagListView.php';
$wgAutoloadClasses['CodeCommentsListView'] = $dir . 'CodeCommentsListView.php';
$wgAutoloadClasses['CodeComment'] = $dir . 'CodeComment.php';
+$wgAutoloadClasses['CodePropChange'] = $dir . 'CodePropChange.php';
$wgAutoloadClasses['SpecialCode'] = $dir . 'SpecialCode.php';
$wgAutoloadClasses['CodeView'] = $dir . 'SpecialCode.php';
$wgAutoloadClasses['SpecialRepoAdmin'] = $dir . 'SpecialRepoAdmin.php';
Modified: trunk/extensions/CodeReview/CodeRevision.php
===================================================================
--- trunk/extensions/CodeReview/CodeRevision.php 2008-11-13 23:10:34 UTC
(rev 43464)
+++ trunk/extensions/CodeReview/CodeRevision.php 2008-11-13 23:18:01 UTC
(rev 43465)
@@ -324,20 +324,22 @@
public function getPropChanges() {
$dbr = wfGetDB( DB_SLAVE );
- $result = $dbr->select( 'code_prop_changes',
+ $result = $dbr->select( array('code_prop_changes','user'),
array(
'cpc_attrib',
'cpc_removed',
'cpc_added',
'cpc_timestamp',
'cpc_user',
- 'cpc_user_text'
+ 'cpc_user_text',
+ 'user_name'
), array(
'cpc_repo_id' => $this->mRepoId,
- 'cpc_rev_id' => $this->mId ),
+ 'cpc_rev_id' => $this->mId,
+ ),
__METHOD__,
- array(
- 'ORDER BY' => 'cpc_timestamp DESC' )
+ array( 'ORDER BY' => 'cpc_timestamp DESC' ),
+ array( 'user' => array('LEFT JOIN','cpc_user =
user_id') )
);
$changes = array();
foreach( $result as $row ) {
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
