Revision: 43467
Author: aaron
Date: 2008-11-13 23:39:14 +0000 (Thu, 13 Nov 2008)
Log Message:
-----------
Move log down
Modified Paths:
--------------
trunk/extensions/CodeReview/CodeRevisionView.php
Modified: trunk/extensions/CodeReview/CodeRevisionView.php
===================================================================
--- trunk/extensions/CodeReview/CodeRevisionView.php 2008-11-13 23:35:18 UTC
(rev 43466)
+++ trunk/extensions/CodeReview/CodeRevisionView.php 2008-11-13 23:39:14 UTC
(rev 43467)
@@ -88,11 +88,6 @@
"});</script>\n";
}
- $changes = $this->formatPropChanges();
- if( $changes ) {
- $html .= "<h2 id='code-changes'>". wfMsgHtml(
'code-prop-changes' ) ."</h2>\n" . $changes;
- }
-
$html .= '<div>' .
Xml::submitButton( wfMsg( 'code-rev-submit' ), array(
'name' => 'wpSave' ) ) .
' ' .
@@ -101,6 +96,11 @@
Xml::submitButton( wfMsg( 'code-rev-comment-preview' ),
array( 'name' => 'wpPreview' ) ) .
'</div>' .
'</form>';
+
+ $changes = $this->formatPropChanges();
+ if( $changes ) {
+ $html .= "<h2 id='code-changes'>". wfMsgHtml(
'code-prop-changes' ) ."</h2>\n" . $changes;
+ }
$wgOut->addHTML( $html );
}
@@ -206,10 +206,8 @@
if( $wgUser->isAllowed( 'codereview-set-status' ) ) {
$repo = $this->mRepo->getName();
$rev = $this->mRev->getId();
- return
- Xml::openElement( 'select', array( 'name' =>
'wpStatus' ) ) .
- $this->buildStatusList() .
- '</select>';
+ return Xml::openElement( 'select', array( 'name' =>
'wpStatus' ) ) .
+ $this->buildStatusList() .
xml::closeElement('select');
} else {
return htmlspecialchars( $this->statusDesc(
$this->mRev->getStatus() ) );
}
@@ -219,10 +217,7 @@
$states = CodeRevision::getPossibleStates();
$out = '';
foreach( $states as $state ) {
- $list[$state] = $this->statusDesc( $state );
- $out .= Xml::option(
- $this->statusDesc( $state ),
- $state,
+ $out .= Xml::option( $this->statusDesc( $state ),
$state,
$this->mRev->getStatus() == $state );
}
return $out;
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
