Revision: 43594
Author: aaron
Date: 2008-11-17 04:34:02 +0000 (Mon, 17 Nov 2008)
Log Message:
-----------
* Add 'reverted' status
* Fix logging for commits with no tag changes
Modified Paths:
--------------
trunk/extensions/CodeReview/CodeReview.i18n.php
trunk/extensions/CodeReview/CodeRevision.php
trunk/extensions/CodeReview/codereview.sql
Added Paths:
-----------
trunk/extensions/CodeReview/archives/
trunk/extensions/CodeReview/archives/codereview-reverted.sql
Modified: trunk/extensions/CodeReview/CodeReview.i18n.php
===================================================================
--- trunk/extensions/CodeReview/CodeReview.i18n.php 2008-11-17 04:30:31 UTC
(rev 43593)
+++ trunk/extensions/CodeReview/CodeReview.i18n.php 2008-11-17 04:34:02 UTC
(rev 43594)
@@ -65,6 +65,7 @@
'code-rev-purge-link' => 'purge',
'code-status-new' => 'new',
'code-status-fixme' => 'fixme',
+ 'code-status-reverted' => 'reverted',
'code-status-resolved' => 'resolved',
'code-status-ok' => 'ok',
'code-status-deferred' => 'deferred',
Modified: trunk/extensions/CodeReview/CodeRevision.php
===================================================================
--- trunk/extensions/CodeReview/CodeRevision.php 2008-11-17 04:30:31 UTC
(rev 43593)
+++ trunk/extensions/CodeReview/CodeRevision.php 2008-11-17 04:34:02 UTC
(rev 43594)
@@ -93,7 +93,7 @@
}
public static function getPossibleStates() {
- return array( 'new', 'fixme', 'resolved', 'ok', 'deferred' );
+ return array( 'new', 'fixme', 'reverted', 'resolved', 'ok',
'deferred' );
}
public function isValidStatus( $status ) {
@@ -410,7 +410,7 @@
);
}
// Log this change
- if( $user && $user->getId() ) {
+ if( ($removeTags || $addTags) && $user && $user->getId() ) {
$dbw->insert( 'code_prop_changes',
array(
'cpc_repo_id' => $this->getRepoId(),
Added: trunk/extensions/CodeReview/archives/codereview-reverted.sql
===================================================================
--- trunk/extensions/CodeReview/archives/codereview-reverted.sql
(rev 0)
+++ trunk/extensions/CodeReview/archives/codereview-reverted.sql
2008-11-17 04:34:02 UTC (rev 43594)
@@ -0,0 +1,2 @@
+ALTER TABLE /*$wgDBprefix*/code_rev
+ CHANGE `cr_status` `cr_status` ENUM( 'new', 'fixme', 'reverted',
'resolved', 'ok' ) NOT NULL DEFAULT 'new';
Property changes on:
trunk/extensions/CodeReview/archives/codereview-reverted.sql
___________________________________________________________________
Added: svn:eol-style
+ native
Modified: trunk/extensions/CodeReview/codereview.sql
===================================================================
--- trunk/extensions/CodeReview/codereview.sql 2008-11-17 04:30:31 UTC (rev
43593)
+++ trunk/extensions/CodeReview/codereview.sql 2008-11-17 04:34:02 UTC (rev
43594)
@@ -52,7 +52,7 @@
-- 'resolved': Issues with this rev have been since resolved
-- 'ok': Reviewed, no issues
-- 'deferred': Not reviewed at this time (usually non-Wikimedia extension)
- cr_status enum('new', 'fixme', 'resolved', 'ok', 'deferred') not null
default 'new',
+ cr_status enum('new', 'fixme', 'reverted', 'resolved', 'ok', 'deferred') not
null default 'new',
-- Base path of this revision :
-- * if the revision change only one file, the file path
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
