Revision: 43630
Author: brion
Date: 2008-11-17 19:51:53 +0000 (Mon, 17 Nov 2008)
Log Message:
-----------
Reverting r43581 "Added a new user right called "alwaysuseskin" that allows the
user to use and set their configured skin even if the wiki administrator has
chosen to disable user skins for the rest of the wiki. Req. by Alexfusco5."
Seems a little weird to me; I'm not quite sure the use case. :)
Comments on the revision note that it needs documentation as well, and the name
is a bit weird. If it is needed/desireable it might be better to just replace
$wgAllowUserSkin with a right 'useskin' or something.
Modified Paths:
--------------
trunk/phase3/includes/User.php
trunk/phase3/includes/specials/SpecialPreferences.php
Modified: trunk/phase3/includes/User.php
===================================================================
--- trunk/phase3/includes/User.php 2008-11-17 19:15:53 UTC (rev 43629)
+++ trunk/phase3/includes/User.php 2008-11-17 19:51:53 UTC (rev 43630)
@@ -2109,7 +2109,7 @@
if ( ! isset( $this->mSkin ) ) {
wfProfileIn( __METHOD__ );
- if( $wgAllowUserSkin || $this->isAllowed(
'alwaysuseskin' ) ) {
+ if( $wgAllowUserSkin ) {
# get the user skin
$userSkin = $this->getOption( 'skin' );
$userSkin = $wgRequest->getVal('useskin',
$userSkin);
Modified: trunk/phase3/includes/specials/SpecialPreferences.php
===================================================================
--- trunk/phase3/includes/specials/SpecialPreferences.php 2008-11-17
19:15:53 UTC (rev 43629)
+++ trunk/phase3/includes/specials/SpecialPreferences.php 2008-11-17
19:51:53 UTC (rev 43630)
@@ -269,7 +269,7 @@
$wgUser->setOption( 'nickname', $this->mNick );
$wgUser->setOption( 'quickbar', $this->mQuickbar );
global $wgAllowUserSkin;
- if( $wgAllowUserSkin || $wgUser->isAllowed( 'alwaysuseskin' ) )
{
+ if( $wgAllowUserSkin ) {
$wgUser->setOption( 'skin', $this->mSkin );
}
global $wgUseTeX;
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
