Revision: 43638
Author:   mkroetzsch
Date:     2008-11-17 21:22:03 +0000 (Mon, 17 Nov 2008)

Log Message:
-----------
added remark on possible todo for even more gentle reaction to unlikely 
problems ...

Modified Paths:
--------------
    trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php

Modified: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php
===================================================================
--- trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php       
2008-11-17 21:18:37 UTC (rev 43637)
+++ trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php       
2008-11-17 21:22:03 UTC (rev 43638)
@@ -234,8 +234,9 @@
                                        $pid = array_search($row->p_id, 
SMWSQLStore2::$special_ids);
                                        if ($pid != false) {
                                                $property = 
SMWPropertyValue::makeProperty($pid);
-                                       } else { // this should be rare (only 
if some extension uses properties of "special" types
+                                       } else { // this should be rare (only 
if some extension uses properties of "special" types)
                                                $proprow = 
$db->selectRow('smw_ids', array('smw_title'), array('smw_id' => $row->p_id), 
'SMW::getSemanticData');
+                                               /// TODO: $proprow may be false 
(inconsistent DB but anyway); maybe check and be gentle in some way
                                                $property = 
SMWPropertyValue::makeProperty($proprow->smw_title);
                                        }
                                        $dv = 
SMWDataValueFactory::newPropertyObjectValue($property);



_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to