Revision: 46202 Author: simetrical Date: 2009-01-25 15:23:56 +0000 (Sun, 25 Jan 2009)
Log Message: ----------- Fix last commit, was broken Per code review by P. Copp: <http://www.mediawiki.org/wiki/Special:Code/MediaWiki/46196/reply/1407#c1407> The conditions on the join would only work if the category had no other page_props. Otherwise it would return incorrect results. Modified Paths: -------------- trunk/phase3/includes/specials/SpecialUnusedcategories.php Modified: trunk/phase3/includes/specials/SpecialUnusedcategories.php =================================================================== --- trunk/phase3/includes/specials/SpecialUnusedcategories.php 2009-01-25 14:46:09 UTC (rev 46201) +++ trunk/phase3/includes/specials/SpecialUnusedcategories.php 2009-01-25 15:23:56 UTC (rev 46202) @@ -27,11 +27,11 @@ {$NScat} as namespace, page_title as title, page_title as value FROM $page LEFT JOIN $categorylinks ON page_title=cl_to - LEFT JOIN $page_props ON pp_page=page_id + LEFT JOIN $page_props ON (pp_page=page_id AND pp_propname = 'ignoreunused') WHERE cl_from IS NULL AND page_namespace = {$NScat} AND page_is_redirect = 0 - AND (pp_propname IS NULL OR pp_propname != 'ignoreunused')"; + AND pp_propname IS NULL"; } function formatResult( $skin, $result ) { _______________________________________________ MediaWiki-CVS mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
