[MediaWiki-CVS] SVN: [48498] trunk/extensions/Gadgets/SpecialGadgets.php

[brion]

Revision: 48498
Author:   brion
Date:     2009-03-17 21:49:13 +0000 (Tue, 17 Mar 2009)

Log Message:
-----------
Revert r48479 "(bug 13287) Edit links don't work as expected. Removed the edit 
links entirely. We already link to the pages anyway and the edit links were 
causing UI clutter."
Removing the links to edit the UI messages means it's necessary to dig around 
and guess at names to update the gadget descriptions. IMHO this is pretty 
terrible, and definitely a step backwards in usability.

Modified Paths:
--------------
    trunk/extensions/Gadgets/SpecialGadgets.php

Modified: trunk/extensions/Gadgets/SpecialGadgets.php
===================================================================
--- trunk/extensions/Gadgets/SpecialGadgets.php 2009-03-17 21:04:40 UTC (rev 
48497)
+++ trunk/extensions/Gadgets/SpecialGadgets.php 2009-03-17 21:49:13 UTC (rev 
48498)
@@ -54,27 +54,29 @@
                foreach ( $gadgets as $section => $entries ) {
                        if ( $section !== false && $section !== '' ) {
                                $t = Title::makeTitleSafe( NS_MEDIAWIKI, 
"Gadget-section-$section$lang" );
-                               $lnk = $t ? $skin->makeLinkObj( $t, 
wfMsgHTML("edit") ) : htmlspecialchars($section);
+                               $lnk = $t ? $skin->makeLinkObj( $t, 
wfMsgHTML("edit"), 'action=edit' ) : htmlspecialchars($section);
                                $ttext = wfMsgExt( "gadget-section-$section", 
$msgOpt );
 
                                if( $listOpen ) {
                                        $wgOut->addHTML( '</ul>' );
                                        $listOpen = false;
                                }
-                               $wgOut->addHTML( "\n<h2>$ttext</h2>\n" );
+                               $wgOut->addHTML( "\n<h2>$ttext &nbsp; &nbsp; 
[$lnk]</h2>\n" );
                        }
 
                        foreach ( $entries as $gname => $code ) {
                                $t = Title::makeTitleSafe( NS_MEDIAWIKI, 
"Gadget-$gname$lang" );
                                if ( !$t ) continue;
 
+                               $lnk = $skin->makeLinkObj( $t, 
wfMsgHTML("edit"), 'action=edit' );
                                $ttext = wfMsgExt( "gadget-$gname", $msgOpt );
 
                                if( !$listOpen ) {
                                        $listOpen = true;
                                        $wgOut->addHTML( '<ul>' );
                                }
-                               $wgOut->addHTML( "<li>$ttext<br />" );
+                               $wgOut->addHTML( "<li>" );
+                               $wgOut->addHTML( "$ttext &nbsp; &nbsp; 
[$lnk]<br />" );
 
                                $wgOut->addHTML( wfMsgHTML( "gadgets-uses" ) . 
wfMsg( 'colon-separator' ) );
 



_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs