Revision: 48525
Author: vasilievvv
Date: 2009-03-18 19:57:25 +0000 (Wed, 18 Mar 2009)
Log Message:
-----------
Fix an XSS bug in AbuseFilter
Modified Paths:
--------------
trunk/extensions/AbuseFilter/AbuseFilter.class.php
trunk/extensions/AbuseFilter/Views/tools.js
Modified: trunk/extensions/AbuseFilter/AbuseFilter.class.php
===================================================================
--- trunk/extensions/AbuseFilter/AbuseFilter.class.php 2009-03-18 19:55:48 UTC
(rev 48524)
+++ trunk/extensions/AbuseFilter/AbuseFilter.class.php 2009-03-18 19:57:25 UTC
(rev 48525)
@@ -326,7 +326,7 @@
}
public static function ajaxEvaluateExpression( $expr ) {
- return self::evaluateExpression( $expr );
+ return htmlspecialchars( self::evaluateExpression( $expr ) );
}
public static function checkConditions( $conds, $vars, $ignoreError =
true ) {
Modified: trunk/extensions/AbuseFilter/Views/tools.js
===================================================================
--- trunk/extensions/AbuseFilter/Views/tools.js 2009-03-18 19:55:48 UTC (rev
48524)
+++ trunk/extensions/AbuseFilter/Views/tools.js 2009-03-18 19:57:25 UTC (rev
48525)
@@ -10,7 +10,7 @@
removeSpinner( 'abusefilter-expr' );
var el = document.getElementById( 'mw-abusefilter-expr-result' );
- changeText( el, response );
+ el.innerHTML = response;
}
function doReautoSubmit()
{
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
