http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56224

Revision: 56224
Author:   ialex
Date:     2009-09-12 10:19:56 +0000 (Sat, 12 Sep 2009)

Log Message:
-----------
Use wfEscapeShellArg() so that the script works correctly when paths contain 
whitespaces 

Modified Paths:
--------------
    trunk/phase3/maintenance/syntaxChecker.php

Modified: trunk/phase3/maintenance/syntaxChecker.php
===================================================================
--- trunk/phase3/maintenance/syntaxChecker.php  2009-09-12 10:01:18 UTC (rev 
56223)
+++ trunk/phase3/maintenance/syntaxChecker.php  2009-09-12 10:19:56 UTC (rev 
56224)
@@ -125,7 +125,7 @@
         * @return boolean
         */
        private function checkFileWithCli( $file ) {
-               $res = exec( 'php -l ' . $file ); 
+               $res = exec( 'php -l ' . wfEscapeShellArg( $file ) ); 
                if( strpos( $res, 'No syntax errors detected' ) === false ) {
                        $this->mFailures[$file] = $res;
                        $this->output( $res . "\n" );



_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to