http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56274

Revision: 56274
Author:   happy-melon
Date:     2009-09-13 17:43:14 +0000 (Sun, 13 Sep 2009)

Log Message:
-----------
Follow-up to r56256, per comments in code review

Modified Paths:
--------------
    branches/happy-melon/phase3/includes/Login.php
    branches/happy-melon/phase3/includes/specials/SpecialCreateAccount.php

Modified: branches/happy-melon/phase3/includes/Login.php
===================================================================
--- branches/happy-melon/phase3/includes/Login.php      2009-09-13 17:35:53 UTC 
(rev 56273)
+++ branches/happy-melon/phase3/includes/Login.php      2009-09-13 17:43:14 UTC 
(rev 56274)
@@ -96,7 +96,7 @@
        public function attemptLogin(){
                
                $code = $this->authenticateUserData();
-               if( $code != self::SUCCESS ){
+               if( $code !== self::SUCCESS ){
                        return $code;
                }
                
@@ -482,7 +482,7 @@
                                        : self::SUCCESS;
                        }
                }
-               return true;
+               return self::SUCCESS;
        }
 
        /**

Modified: branches/happy-melon/phase3/includes/specials/SpecialCreateAccount.php
===================================================================
--- branches/happy-melon/phase3/includes/specials/SpecialCreateAccount.php      
2009-09-13 17:35:53 UTC (rev 56273)
+++ branches/happy-melon/phase3/includes/specials/SpecialCreateAccount.php      
2009-09-13 17:43:14 UTC (rev 56274)
@@ -249,7 +249,7 @@
                                global $wgOut;
                                $self = SpecialPage::getTitleFor( 'Userlogin' );
                                $wgOut->setPageTitle( wfMsgHtml( 
'accountcreated' ) );
-                               $wgOut->addHTML( wfMsgWikiHtml( 
'accountcreatedtext', $this->mLogin->mUser->getName() ) );
+                               $wgOut->addWikiMsg( 'accountcreatedtext', 
$this->mLogin->mUser->getName() );
                                $wgOut->returnToMain( false, $self );
                                return true;
                        }



_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to