http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56372

Revision: 56372
Author:   aaron
Date:     2009-09-15 17:13:40 +0000 (Tue, 15 Sep 2009)

Log Message:
-----------
Added $wgFeedbackSizeThreshhold

Modified Paths:
--------------
    trunk/extensions/ReaderFeedback/ReaderFeedback.class.php
    trunk/extensions/ReaderFeedback/ReaderFeedback.php
    trunk/extensions/ReaderFeedback/specialpages/LikedPages_body.php
    trunk/extensions/ReaderFeedback/specialpages/ProblemPages_body.php

Modified: trunk/extensions/ReaderFeedback/ReaderFeedback.class.php
===================================================================
--- trunk/extensions/ReaderFeedback/ReaderFeedback.class.php    2009-09-15 
17:07:33 UTC (rev 56371)
+++ trunk/extensions/ReaderFeedback/ReaderFeedback.class.php    2009-09-15 
17:13:40 UTC (rev 56372)
@@ -43,6 +43,11 @@
                return self::$feedbackTagWeight[$tag];
        }
        
+       public static function getFeedbackSize() {
+               global $wgFeedbackSizeThreshhold;
+               return (int)$wgFeedbackSizeThreshhold;
+       }
+       
        ################# Utility functions #################
 
        /**

Modified: trunk/extensions/ReaderFeedback/ReaderFeedback.php
===================================================================
--- trunk/extensions/ReaderFeedback/ReaderFeedback.php  2009-09-15 17:07:33 UTC 
(rev 56371)
+++ trunk/extensions/ReaderFeedback/ReaderFeedback.php  2009-09-15 17:13:40 UTC 
(rev 56372)
@@ -23,10 +23,6 @@
        exit( 1 );
 }
 
-# Number of recent reviews to be a decent sample size
-if( !defined('READER_FEEDBACK_SIZE') )
-       define('READER_FEEDBACK_SIZE',15);
-
 $wgExtensionCredits['specialpage'][] = array(
        'path'           => __FILE__,
        'name'           => 'Reader Feedback',
@@ -56,6 +52,9 @@
 );
 # How many seconds back should the average rating for a page be based on?
 $wgFeedbackAge = 7 * 24 * 3600;
+# What number of page votes (for the average above) is considered significant?
+# (number of recent reviews to be a decent sample size)
+$wgFeedbackSizeThreshhold = 15;
 # How long before stats page is updated?
 $wgFeedbackStatsAge = 2 * 3600; // 2 hours
 # Limit people from spamming the system

Modified: trunk/extensions/ReaderFeedback/specialpages/LikedPages_body.php
===================================================================
--- trunk/extensions/ReaderFeedback/specialpages/LikedPages_body.php    
2009-09-15 17:07:33 UTC (rev 56371)
+++ trunk/extensions/ReaderFeedback/specialpages/LikedPages_body.php    
2009-09-15 17:13:40 UTC (rev 56372)
@@ -122,7 +122,7 @@
                $x = 3.5;
                $conds[] = "rfp_ave_val > $x";
                // Reasonable sample
-               $conds[] = 'rfp_count >= '.READER_FEEDBACK_SIZE;
+               $conds[] = 'rfp_count >= '.ReaderFeedback::getFeedbackSize();
                return array(
                        'tables' => array('reader_feedback_pages','page'),
                        'fields' => 
'page_namespace,page_title,page_len,rfp_ave_val',

Modified: trunk/extensions/ReaderFeedback/specialpages/ProblemPages_body.php
===================================================================
--- trunk/extensions/ReaderFeedback/specialpages/ProblemPages_body.php  
2009-09-15 17:07:33 UTC (rev 56371)
+++ trunk/extensions/ReaderFeedback/specialpages/ProblemPages_body.php  
2009-09-15 17:13:40 UTC (rev 56372)
@@ -122,7 +122,7 @@
                $x = 2;
                $conds[] = "rfp_ave_val < $x";
                // Reasonable sample
-               $conds[] = 'rfp_count >= '.READER_FEEDBACK_SIZE;
+               $conds[] = 'rfp_count >= '.ReaderFeedback::getFeedbackSize();
                return array(
                        'tables' => array('reader_feedback_pages','page'),
                        'fields' => 
'page_namespace,page_title,page_len,rfp_ave_val',



_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to