http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70030
Revision: 70030
Author: simetrical
Date: 2010-07-27 19:55:47 +0000 (Tue, 27 Jul 2010)
Log Message:
-----------
Remove dead code added in r36814
None of the constructors will set $this->mTitle but not $this->mName,
and those are both private member variables. r69813 demonstrates that
no one had ever hit this code since it was first added in June 2008,
because it would have resulted in a fatal.
Modified Paths:
--------------
trunk/phase3/includes/Category.php
Modified: trunk/phase3/includes/Category.php
===================================================================
--- trunk/phase3/includes/Category.php 2010-07-27 19:36:07 UTC (rev 70029)
+++ trunk/phase3/includes/Category.php 2010-07-27 19:55:47 UTC (rev 70030)
@@ -25,10 +25,6 @@
* @return bool True on success, false on failure.
*/
protected function initialize() {
- if ( $this->mName === null && $this->mTitle ) {
- $this->mName = $this->mTitle->getDBkey();
- }
-
if ( $this->mName === null && $this->mID === null ) {
throw new MWException( __METHOD__ . ' has both names
and IDs null' );
} elseif ( $this->mID === null ) {
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
