http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71825
Revision: 71825
Author: reedy
Date: 2010-08-27 23:38:37 +0000 (Fri, 27 Aug 2010)
Log Message:
-----------
Bug 24840 - CR should give some sort of error messages when revision can't be
found
Tweak message quoting and use '''
Modified Paths:
--------------
trunk/extensions/CodeReview/CodeReview.i18n.php
trunk/extensions/CodeReview/ui/CodeRevisionView.php
Modified: trunk/extensions/CodeReview/CodeReview.i18n.php
===================================================================
--- trunk/extensions/CodeReview/CodeReview.i18n.php 2010-08-27 23:31:03 UTC
(rev 71824)
+++ trunk/extensions/CodeReview/CodeReview.i18n.php 2010-08-27 23:38:37 UTC
(rev 71825)
@@ -23,7 +23,7 @@
'code-prop-changes' => 'Status & tagging log',
'codereview-desc' => '[[Special:Code|Code review tool]] with
[[Special:RepoAdmin|Subversion support]]',
'code-no-repo' => 'No repository configured!',
- 'code-repo-not-found' => 'Repository <b>$1</b> does not exist!',
+ 'code-repo-not-found' => "Repository '''$1''' does not exist!",
'code-load-diff' => 'Loading diff…',
'code-notes' => 'recent comments',
'code-statuschanges' => 'status changes',
@@ -81,6 +81,7 @@
'code-rev-diff-too-large' => 'The diff is too large to display.',
'code-rev-purge-link' => 'purge',
'code-rev-total' => 'Total number of results: $1',
+ 'code-rev-not-found' => "Revision '''$1''' does not exist!",
'code-status-new' => 'new',
'code-status-fixme' => 'fixme',
'code-status-reverted' => 'reverted',
Modified: trunk/extensions/CodeReview/ui/CodeRevisionView.php
===================================================================
--- trunk/extensions/CodeReview/ui/CodeRevisionView.php 2010-08-27 23:31:03 UTC
(rev 71824)
+++ trunk/extensions/CodeReview/ui/CodeRevisionView.php 2010-08-27 23:38:37 UTC
(rev 71825)
@@ -7,8 +7,9 @@
global $wgRequest;
parent::__construct();
$this->mRepo = CodeRepository::newFromName( $repoName );
+ $this->mRevId = intval( ltrim( $rev, 'r' ) );
$this->mRev = $this->mRepo ?
- $this->mRepo->getRevision( intval( ltrim( $rev, 'r' ) )
) : null;
+ $this->mRepo->getRevision( $this->mRevId ) : null;
$this->mPreviewText = false;
# Search path for navigation links
$this->mPath = htmlspecialchars( trim( $wgRequest->getVal(
'path' ) ) );
@@ -37,6 +38,7 @@
return;
}
if ( !$this->mRev ) {
+ $wgOut->addWikiMsg( 'code-rev-not-found', $this->mRevId
);
$view = new CodeRevisionListView(
$this->mRepo->getName() );
$view->execute();
return;
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
