http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72186
Revision: 72186
Author: kaldari
Date: 2010-09-02 01:54:58 +0000 (Thu, 02 Sep 2010)
Log Message:
-----------
better code for $this->language and $this->project
Modified Paths:
--------------
trunk/extensions/CentralNotice/BannerLoader.php
Modified: trunk/extensions/CentralNotice/BannerLoader.php
===================================================================
--- trunk/extensions/CentralNotice/BannerLoader.php 2010-09-02 01:20:18 UTC
(rev 72185)
+++ trunk/extensions/CentralNotice/BannerLoader.php 2010-09-02 01:54:58 UTC
(rev 72186)
@@ -4,8 +4,8 @@
* Generates banner HTML files
*/
class BannerLoader extends UnlistedSpecialPage {
- var $project = 'wikipedia';
- var $language = 'en';
+ var $project = 'wikipedia'; // Project name
+ var $language = 'en'; // User language
protected $sharedMaxAge = 22; // Cache for ? hours on the server side
protected $maxAge = 0; // No client-side banner caching so we get all
impressions
protected $contentType = 'text/html';
@@ -21,12 +21,13 @@
$wgOut->disable();
$this->sendHeaders();
- // If a language is specified in the query string, use it
- if ( $wgRequest->getText( 'language' ) ) {
- $this->language = htmlspecialchars(
$wgRequest->getText( 'language' ) );
- }
+ // Get user language from the query string
+ $this->language = htmlspecialchars( $wgRequest->getText(
'language', 'en' ) );
- if ( $wgRequest->getText( 'banner') ) {
+ // Get project name from the query string
+ $this->project = htmlspecialchars( $wgRequest->getText(
'project', 'wikipedia' ) );
+
+ if ( $wgRequest->getText( 'banner' ) ) {
$bannerName = htmlspecialchars( $wgRequest->getText(
'banner' ) );
$content = $this->getHtmlNotice( $bannerName );
if ( strlen( $content ) == 0 ) {
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
