http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72424
Revision: 72424
Author: platonides
Date: 2010-09-05 13:21:04 +0000 (Sun, 05 Sep 2010)
Log Message:
-----------
(bug 24977) Remove the duplicate Access Key to compare selected revision in
history
Modified Paths:
--------------
trunk/phase3/RELEASE-NOTES
trunk/phase3/includes/HistoryPage.php
Modified: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES 2010-09-05 13:20:52 UTC (rev 72423)
+++ trunk/phase3/RELEASE-NOTES 2010-09-05 13:21:04 UTC (rev 72424)
@@ -312,6 +312,8 @@
* (bug 20744) Wiki forgets about an uploaded file
* (bug 17913) Don't show "older edit" when no older edit available
* (bug 6204) TOC not properly rendered when using $wgMaxTocLevel
+* (bug 24977) The accesskey in history page now lead directly to the diff
+ instead of alterning focus between the two buttons.
=== API changes in 1.17 ===
* (bug 22738) Allow filtering by action type on query=logevent.
Modified: trunk/phase3/includes/HistoryPage.php
===================================================================
--- trunk/phase3/includes/HistoryPage.php 2010-09-05 13:20:52 UTC (rev
72423)
+++ trunk/phase3/includes/HistoryPage.php 2010-09-05 13:21:04 UTC (rev
72424)
@@ -380,15 +380,19 @@
$s .= Html::hidden( 'title', $this->title->getPrefixedDbKey() )
. "\n";
$s .= Html::hidden( 'action', 'historysubmit' ) . "\n";
+ $s .= '<div>' . $this->submitButton( wfMsg(
'compareselectedversions'),
+ array( 'class' => 'historysubmit' ) ) . "\n";
+
$this->buttons = '<div>';
$this->buttons .= $this->submitButton( wfMsg(
'compareselectedversions'),
array( 'class' => 'historysubmit' )
+
$wgUser->getSkin()->tooltipAndAccessKeyAttribs( 'compareselectedversions' )
) . "\n";
+
if( $wgUser->isAllowed('deleterevision') ) {
$float = $wgContLang->alignEnd();
# Note bug #20966, <button> is non-standard in IE<8
- $this->buttons .= Html::element( 'button',
+ $element = Html::element( 'button',
array(
'type' => 'submit',
'name' => 'revisiondelete',
@@ -398,11 +402,13 @@
),
wfMsg( 'showhideselectedversions' )
) . "\n";
+ $s .= $element;
+ $this->buttons .= $element;
}
if( $wgUser->isAllowed( 'revisionmove' ) ) {
$float = $wgContLang->alignEnd();
# Note bug #20966, <button> is non-standard in IE<8
- $this->buttons .= Html::element( 'button',
+ $element = Html::element( 'button',
array(
'type' => 'submit',
'name' => 'revisionmove',
@@ -412,9 +418,11 @@
),
wfMsg( 'revisionmoveselectedversions' )
) . "\n";
+ $s .= $element;
+ $this->buttons .= $element;
}
$this->buttons .= '</div>';
- $s .= $this->buttons . '<ul id="pagehistory">' . "\n";
+ $s .= '</div><ul id="pagehistory">' . "\n";
return $s;
}
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
