http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72517
Revision: 72517
Author: aaron
Date: 2010-09-07 03:43:22 +0000 (Tue, 07 Sep 2010)
Log Message:
-----------
Typecast and comment tweaks
Modified Paths:
--------------
trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php
Modified: trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php
===================================================================
--- trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php
2010-09-07 03:37:56 UTC (rev 72516)
+++ trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php
2010-09-07 03:43:22 UTC (rev 72517)
@@ -223,13 +223,13 @@
$this->mForm = $form;
$this->live = (bool)$live;
# Must be a content page...
-
if ( !is_null( $namespace ) ) {
- $namespace = intval( $namespace );
+ $namespace = (int)$namespace;
}
$vnamespaces = FlaggedRevs::getReviewNamespaces();
+ # Must be a single NS for perfomance reasons
if ( is_null( $namespace ) || !in_array( $namespace,
$vnamespaces ) ) {
- $namespace = !$vnamespaces ? - 1 : $vnamespaces[0];
+ $namespace = !$vnamespaces ? -1 : $vnamespaces[0];
}
$this->namespace = $namespace;
$this->category = $category ? str_replace( ' ', '_', $category
) : null;
@@ -270,6 +270,7 @@
$fields[] = 'cl_sortkey';
$conds['cl_to'] = $this->category;
$conds[] = 'cl_from = page_id';
+ # Note: single NS always specified
if( $this->namespace == NS_FILE ) {
$conds['cl_type'] = 'file';
} elseif( $this->namespace == NS_CATEGORY ) {
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
