http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72747
Revision: 72747
Author: platonides
Date: 2010-09-10 20:31:44 +0000 (Fri, 10 Sep 2010)
Log Message:
-----------
(Bug 25138) ApiUndelete begins a transaction, but does not commit.
The UI doesn't use a transaction either, although it seems appropiate.
The begin() should be moved into PageArchive::undelete()
Modified Paths:
--------------
trunk/phase3/includes/api/ApiUndelete.php
Modified: trunk/phase3/includes/api/ApiUndelete.php
===================================================================
--- trunk/phase3/includes/api/ApiUndelete.php 2010-09-10 20:29:12 UTC (rev
72746)
+++ trunk/phase3/includes/api/ApiUndelete.php 2010-09-10 20:31:44 UTC (rev
72747)
@@ -69,8 +69,6 @@
}
$pa = new PageArchive( $titleObj );
- $dbw = wfGetDB( DB_MASTER );
- $dbw->begin();
$retval = $pa->undelete( ( isset( $params['timestamps'] ) ?
$params['timestamps'] : array() ), $params['reason'] );
if ( !is_array( $retval ) ) {
$this->dieUsageMsg( array( 'cannotundelete' ) );
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
