http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72977

Revision: 72977
Author:   nikerabbit
Date:     2010-09-14 14:34:09 +0000 (Tue, 14 Sep 2010)

Log Message:
-----------
Improve printf formatter check to support positional parameters

Modified Paths:
--------------
    trunk/extensions/Translate/MessageChecks.php
    trunk/extensions/Translate/groups/StatusNet/StatusNet.yaml

Modified: trunk/extensions/Translate/MessageChecks.php
===================================================================
--- trunk/extensions/Translate/MessageChecks.php        2010-09-14 14:01:07 UTC 
(rev 72976)
+++ trunk/extensions/Translate/MessageChecks.php        2010-09-14 14:34:09 UTC 
(rev 72977)
@@ -265,12 +265,10 @@
                        $definition = $message->definition();
                        $translation = $message->translation();
 
-                       preg_match_all( '/%[sd]/U', $definition, $defVars );
-                       preg_match_all( '/%[sd]/U', $translation, $transVars );
+                       preg_match_all( '/%(\d+\$)[sduf]/U', $definition, 
$defVars );
+                       preg_match_all( '/%(\d+\$)[sduf]/U', $translation, 
$transVars );
 
-                       /**
-                        * Check for missing variables in the translation
-                        */
+                       // Check for missing variables in the translation
                        $subcheck = 'missing';
                        $params = self::compareArrays( $defVars[0], 
$transVars[0] );
 
@@ -283,9 +281,7 @@
                                );
                        }
 
-                       /**
-                        * Check for unknown variables in the translation
-                        */
+                       // Check for unknown variables in the translatio
                        $subcheck = 'unknown';
                        $params = self::compareArrays( $transVars[0], 
$defVars[0] );
 

Modified: trunk/extensions/Translate/groups/StatusNet/StatusNet.yaml
===================================================================
--- trunk/extensions/Translate/groups/StatusNet/StatusNet.yaml  2010-09-14 
14:01:07 UTC (rev 72976)
+++ trunk/extensions/Translate/groups/StatusNet/StatusNet.yaml  2010-09-14 
14:34:09 UTC (rev 72977)
@@ -23,4 +23,9 @@
     zh-hant: zh_TW
   header: |
     # This file is distributed under the same license as the StatusNet package.
-    #
\ No newline at end of file
+    #
+
+CHECKER:
+  class: MessageChecker
+  checks:
+    - printfCheck



_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to