http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73391
Revision: 73391
Author: tparscal
Date: 2010-09-20 19:04:16 +0000 (Mon, 20 Sep 2010)
Log Message:
-----------
Fixed bug caused by unset( $this->mSkin ) in User::setOption which was removing
the member, not just setting it to null, which would cause errors when later on
checking if ( ! $this->mSkin ) such as in User::getSkin. By using $this->mSkin
= null instead, the same effect of showing the new skin preference immediately
on change in Special:Preferences without causing errors.
Modified Paths:
--------------
trunk/phase3/includes/User.php
Modified: trunk/phase3/includes/User.php
===================================================================
--- trunk/phase3/includes/User.php 2010-09-20 18:46:13 UTC (rev 73390)
+++ trunk/phase3/includes/User.php 2010-09-20 19:04:16 UTC (rev 73391)
@@ -2006,7 +2006,7 @@
if ( $oname == 'skin' ) {
# Clear cached skin, so the new one displays
immediately in Special:Preferences
- unset( $this->mSkin );
+ $this->mSkin = null;
}
// Explicitly NULL values should refer to defaults
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
