http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73674
Revision: 73674
Author: neilk
Date: 2010-09-24 19:11:57 +0000 (Fri, 24 Sep 2010)
Log Message:
-----------
removing unsafe for..in over array. Clarifying when for..in used properly.
(for..in is generally unsafe, and specifically, Resource Loader adds methods to
Array.prototype)
Modified Paths:
--------------
branches/uploadwizard/extensions/UploadWizard/resources/language/mw.Parser.js
Modified:
branches/uploadwizard/extensions/UploadWizard/resources/language/mw.Parser.js
===================================================================
---
branches/uploadwizard/extensions/UploadWizard/resources/language/mw.Parser.js
2010-09-24 18:49:19 UTC (rev 73673)
+++
branches/uploadwizard/extensions/UploadWizard/resources/language/mw.Parser.js
2010-09-24 19:11:57 UTC (rev 73674)
@@ -19,8 +19,8 @@
* @param {Object} magicSet key:callback
*/
mw.addTemplateTransform = function( magicSet ) {
- for ( var i in magicSet ) {
- pMagicSet[ i ] = magicSet[i];
+ for ( var name in magicSet ) {
+ pMagicSet[name] = magicSet[name];
}
};
@@ -111,7 +111,7 @@
paramSet.splice( 0, 1 );
if ( paramSet.length ) {
templateObject.param = new Array();
- for ( var pInx in paramSet ) {
+ for ( var pInx = 0; pInx <
paramSet.length; pInx++ ) {
var paramString = paramSet[
pInx ];
// check for empty param
if ( paramString == '' ) {
@@ -206,7 +206,7 @@
if ( node['child'] ) {
// swap all the kids:
- for ( var i in node['child'] ) {
+ for ( var i = 0; i <
node['child'].length; i++ ) {
var nodeText =
recurse_magic_swap( node['child'][i] );
// swap it into current
if ( node.text ) {
@@ -249,7 +249,7 @@
var tmplSet = new Array();
function getMatchingTmpl( node ) {
if ( node['child'] ) {
- for ( var i in node['child'] ) {
+ for ( var i = 0; i <
node['child'].length; i++ ) {
getMatchingTmpl( node['child']
);
}
}
@@ -320,4 +320,4 @@
}
};
-}) ( window.mw );
\ No newline at end of file
+}) ( window.mw );
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
