http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73742
Revision: 73742
Author: reedy
Date: 2010-09-25 11:30:45 +0000 (Sat, 25 Sep 2010)
Log Message:
-----------
Bug 25290 - ArticleAssessmentPilot: parameter validation
Use 'limit', type, which if value provided > MAX, it will use the defined max
Maybe we should have a PARAM_MAX_ENFORCE. Rather than just warning!
Modified Paths:
--------------
trunk/extensions/ArticleAssessmentPilot/api/ApiArticleAssessment.php
trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php
Modified: trunk/extensions/ArticleAssessmentPilot/api/ApiArticleAssessment.php
===================================================================
--- trunk/extensions/ArticleAssessmentPilot/api/ApiArticleAssessment.php
2010-09-25 11:00:16 UTC (rev 73741)
+++ trunk/extensions/ArticleAssessmentPilot/api/ApiArticleAssessment.php
2010-09-25 11:30:45 UTC (rev 73742)
@@ -122,7 +122,7 @@
*/
private function insertUserRatings( $pageId, $revisionId, $user,
$token, $ratingId, $ratingValue ) {
$dbw = wfGetDB( DB_MASTER );
-
+
$timestamp = $dbw->timestamp();
$dbw->insert(
@@ -179,7 +179,7 @@
),
'anontoken' => null,
);
-
+
foreach( $wgArticleAssessmentRatings as $rating ) {
$ret["r{$rating}"] = array(
ApiBase::PARAM_TYPE => 'integer',
@@ -209,7 +209,7 @@
'Submit article assessments'
);
}
-
+
public function mustBePosted() {
return true;
}
Modified:
trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php
===================================================================
--- trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php
2010-09-25 11:00:16 UTC (rev 73741)
+++ trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php
2010-09-25 11:30:45 UTC (rev 73742)
@@ -26,7 +26,7 @@
if ( $params['userrating'] ) {
global $wgUser;
-
+
$leftJoinConds = array(
'aa_page_id=aap_page_id',
'aa_rating_id=aap_rating_id',
@@ -95,7 +95,7 @@
//Only can actually be "stale" if the user has rated the
article before
if ( $params['userrating'] && $userRatedArticle ) {
$dbr = wfGetDb( DB_SLAVE );
-
+
global $wgArticleAssessmentStaleCount;
$res = $dbr->select(
_______________________________________________
MediaWiki-CVS mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
